On 10.07.2008 13:46, Peter Stuge wrote: > On Wed, Jul 09, 2008 at 07:21:56PM +0400, Sergei Antonov wrote: > >>> Please apply the workaround patch attached to the ticket for now: >>> http://tracker.coreboot.org/trac/coreboot/attachment/ticket/102/fr.idheur.kludge.patch >>> >> Why not fix the problem in svn? >> > > A different approach to image identification is being worked on. > > > >> Passing const char* to isprint() is apparently an error. >> > > Yes, but the heuristic is broken anyway. The new approach isn't ready > yet. > > > On Wed, Jul 09, 2008 at 07:53:48PM +0100, Tiago Marques wrote: > >> I've compiled flashrom on x86_64 not too long ago, without any >> problem. >> > > Yes, r3408 that breaks x86_64 was committed a week ago. >
I posted a complete rewrite of image identification with greatly improved readability a few days ago. The code is IMHO even more readable than the original. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
