On 10.07.2008 16:51, Stefan Reinauer wrote:
> [EMAIL PROTECTED] wrote:
>
>> Modified: coreboot-v3/device/pci_device.c
>> ===================================================================
>> --- coreboot-v3/device/pci_device.c 2008-07-03 19:42:05 UTC (rev 692)
>> +++ coreboot-v3/device/pci_device.c 2008-07-09 21:21:39 UTC (rev 693)
>> @@ -50,6 +50,7 @@
>> #if CONFIG_CARDBUS_PLUGIN_SUPPORT == 1
>> #include <device/cardbus.h>
>> #endif
>> +#include <statictree.h>
>>
>> u8 pci_moving_config8(struct device *dev, unsigned int reg)
>> {
>> @@ -627,19 +628,18 @@
>> /* Set the subsystem vendor and device ID for mainboard devices. */
>> ops = ops_pci(dev);
>>
>> -#if defined(CONFIG_MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID) && \
>> - defined(CONFIG_MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID)
>> +#ifdef HAVE_MAINBOARD_PCI_SUBSYSTEM_ID
>> if (dev->on_mainboard && ops && ops->set_subsystem) {
>> printk(BIOS_DEBUG,
>> "%s: Setting subsystem VID/DID to %02x/%02x\n",
>> - dev_path(dev), CONFIG_MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID,
>> - CONFIG_MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID);
>> + dev_path(dev), mainboard_pci_subsystem_vendor,
>> + mainboard_pci_subsystem_device);
>>
>> - ops->set_subsystem(dev,
>> - CONFIG_MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID,
>> - CONFIG_MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID);
>> + ops->set_subsystem(dev, mainboard_pci_subsystem_vendor,
>> + mainboard_pci_subsystem_device);
>> }
>> #endif
>> +
>> command = pci_read_config16(dev, PCI_COMMAND);
>> command |= dev->command;
>> command |= (PCI_COMMAND_PARITY + PCI_COMMAND_SERR); // Error check.
>>
>
> This code will overwrite the bars of PCIe prefmem resources. Nothing
> new, but it's broken as is.
>
Please either add a #warning to the code in the offending location or
post a bugfix. Thanks!
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
