On Sun, Aug 3, 2008 at 10:03 AM, Uwe Hermann <[EMAIL PROTECTED]> wrote: > On Sat, Aug 02, 2008 at 02:04:51PM -0700, ron minnich wrote: >> Index: southbridge/nvidia/mcp55/stage1.c >> =================================================================== >> --- southbridge/nvidia/mcp55/stage1.c (revision 713) >> +++ southbridge/nvidia/mcp55/stage1.c (working copy) >> @@ -19,6 +19,17 @@ >> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA >> */ >> >> +#include <console.h> >> +#include <io.h> >> +#include <device/device.h> >> +#include <device/pci.h> > > >> +#include <device/pci_ids.h> >> +#include <device/pci_ops.h> > > These two are not needed, pci.h already includes them.
fixed. > > >> -static uint32_t final_reg; >> +static u32 final_reg; > > Is the static really needed or a romcc artifact? > not needed, but a good idea in general. Committed revision 716. ron -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
