On 10.08.2008 02:55, Peter Stuge wrote: > On Sun, Aug 10, 2008 at 02:45:24AM +0200, Carl-Daniel Hailfinger wrote: > >> Please note the following pitfalls: >> - Adding a new global variable is not as easy as it looks. >> - Don't try to add one without consulting me. >> > > I'm afraid the last pitfall is a blocker for me. Please document the > real problem either in the commit message or preferably in code near > where I would be tempted to add more variables. >
Short version: You need to fix all stage0 asm code if you add a new variable. And the stage0 asm code modification is nontrivial (size of the struct, alignment, initialization, order of struct members). Depending on your compiler, real breakage may happen. > Thank you. > I hope the short explanation above is good enough for the moment. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
