On 11.08.2008 06:11, ron minnich wrote: > On Sun, Aug 10, 2008 at 5:30 PM, Carl-Daniel Hailfinger > <[EMAIL PROTECTED]> wrote: > >> On 11.08.2008 02:18, ron minnich wrote: >> >>> the k8 north makefile and raminit.c are committed rev 736. >>> >>> Current status: >>> Index: southbridge/nvidia/mcp55/mcp55_smbus.h >>> >>> >> I believe that one was never posted. >> > > attached. > > New arch/x86/Kconfig attached. I responded to all the comments save this one: > >> + >> +config K8_SCAN_PCI_BUS >> + hex >> + default 0 if CPU_AMD_K8 >> + help >> + Whether to scan the PCI bus on startup >> >> > > >> Since when do we not scan the PCI bus by default? >> > > >> + >> +config K8_ALLOCATE_IO_RANGE >> + hex >> + default 0 if CPU_AMD_K8 >> + help >> + Whether to allocate IO space on startup >> >> > > >> Same question here. >> > > > Stage 1 again. Let's keep in mind, the rules in stage1 vary by > mainboard for good reasons in most cases. I don't want to get into > this at this time, this code has been this way for years on v2. >
> New config variables for K8. > > Signed-off-by: Ronald G. Minnich <[EMAIL PROTECTED]> > > Index: arch/x86/Kconfig > Agreed. I tripped on the "on startup" phrase. Your change to "in stage1" is perfect. Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> > Move code to a .c file -- now there's an idea! > > Signed-off-by: Ronald G. Minnich <[EMAIL PROTECTED]> > > Index: southbridge/nvidia/mcp55/mcp55_smbus.h > Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
