On Mon, Aug 11, 2008 at 3:37 AM, Carl-Daniel Hailfinger
>> +#warning Figure out if we want usb debug direct
>>
>
> Hm?
>
>> +#define CONFIG_USBDEBUG_DIRECT 0
>>
>
> Move that one to a Kconfig variable.

we might as well. I just don't know if we ever used it. Anyone?

>
>> +#if CONFIG_USBDEBUG_DIRECT
>> +#include <usbdebug_direct.h>
>> +#endif
>> +
>> +// yeah right. not yet. extern struct ehci_debug_info dbg_info;
>>
>
> More context, please.

I don't know what it is.

>
> Separate function please.

Again, I left the warning there because we don't want to do this the
way we did in v2. So it is yet to be resolved.


ron

--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to