Author: hailfinger
Date: 2008-08-14 03:40:31 +0200 (Thu, 14 Aug 2008)
New Revision: 759
Modified:
coreboot-v3/device/hypertransport.c
coreboot-v3/device/pci_device.c
Log:
The device code had several unclear messages, leading to
confusion when analyzing the logs. Improve readability.
This code may be obsolete, but that's not entriely sure yet.
Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>
Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>
Modified: coreboot-v3/device/hypertransport.c
===================================================================
--- coreboot-v3/device/hypertransport.c 2008-08-14 00:02:27 UTC (rev 758)
+++ coreboot-v3/device/hypertransport.c 2008-08-14 01:40:31 UTC (rev 759)
@@ -580,10 +580,11 @@
*/
if (old_devices) {
struct device *left;
+ printk(BIOS_INFO, "HT: Left over static devices:\n");
for (left = old_devices; left; left = left->sibling) {
- printk(BIOS_DEBUG, "%s\n", dev_path(left));
+ printk(BIOS_INFO, "%s\n", dev_path(left));
}
- printk(BIOS_ERR, "HT: Left over static devices.\n");
+ printk(BIOS_INFO, "HT: End of leftover list.\n");
/* Put back the left over static device, and let
* pci_scan_bus() disable it.
*/
Modified: coreboot-v3/device/pci_device.c
===================================================================
--- coreboot-v3/device/pci_device.c 2008-08-14 00:02:27 UTC (rev 758)
+++ coreboot-v3/device/pci_device.c 2008-08-14 01:40:31 UTC (rev 759)
@@ -883,7 +883,7 @@
dev = 0;
printk(BIOS_SPEW, "%s: list is %p, *list is %p\n", __func__, list,
*list);
- for (/* */; *list; list = &(*list)->sibling) {
+ for (; *list; list = &(*list)->sibling) {
printk(BIOS_SPEW, "%s: check dev %s \n", __func__,
(*list)->dtsname);
if ((*list)->path.type != DEVICE_PATH_PCI) {
@@ -1122,10 +1122,11 @@
*/
if (old_devices) {
struct device *left;
+ printk(BIOS_INFO, "PCI: Left over static devices:\n");
for (left = old_devices; left; left = left->sibling) {
- printk(BIOS_SPEW, "%s\n", left->dtsname);
+ printk(BIOS_INFO, "%s\n", left->dtsname);
}
- banner(BIOS_SPEW, "PCI: Left over static devices.\n");
+ printk(BIOS_INFO, "PCI: End of leftover list.\n");
}
/* For all children that implement scan_bus() (i.e. bridges)
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
