On Mon, Aug 18, 2008 at 10:02 AM, Stefan Reinauer <[EMAIL PROTECTED]> wrote: > Carl-Daniel Hailfinger wrote: >> On 18.08.2008 18:57, Stefan Reinauer wrote: >> >>> ron minnich wrote: >>> >>> >>>> On Mon, Aug 18, 2008 at 9:48 AM, Carl-Daniel Hailfinger >>>> <[EMAIL PROTECTED]> wrote: >>>> >>>> >>>> >>>> >>>> >>>>> It seems the K8 code is using CONFIG_LOGICAL_CPUS for that. >>>>> >>>>> >>>>> >>>> I think the config logical cpus is for multicore. The name is >>>> confusing and I intend to change it. >>>> >>>> >>>> >>>> >>>> >>>>> CONFIG_SMP does only control spinlocks and enables the LAPIC >>>>> unconditionally. >>>>> >>>>> >>>>> >>>>> >>>>>>> - Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for >>>>>>> Qemu. >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> not sure on LX but it is unlikely? >>>>>> >>>>>> >>>>>> >>>>>> >>>>> Jordan says the LX doesn't support it. >>>>> >>>>> >>>>> >>>>> >>>> so the option should not be available. >>>> >>>> >>>> >>> Those options are part of the hardware description, not real user >>> options. They're there only because of short comings of our current dts >>> scheme. >>> >>> >> >> If they are not user options, they shouldn't be selectable at all. >> > > Not in the user interface. Indeed. > > And, correctly, they were not selectable by the user. > > Please, guys, don't fix stuff that ain't broken. >
I didn't see that they were selectable by the user. Not all Kconfig variables are selectable by the user; they should be there nonetheless, I assume. Let me know if I made a mistake in some of the setup. We can fix the non-broken stuff I "fixed". ron -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
