Author: hailfinger
Date: 2008-09-04 17:35:49 +0200 (Thu, 04 Sep 2008)
New Revision: 857
Modified:
coreboot-v3/lib/console.c
Log:
Fix initial printk buffer address initialization. This was broken in
r785 (move from explicit asm to implicit C) and unfortunately qemu never
triggered the bug, only real hardware did. That's because qemu will not
spew an error on access to RAM before RAM is enabled.
Thanks to Ron for bisecting this.
Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>
Acked-by: Ronald G. Minnich <[EMAIL PROTECTED]>
Modified: coreboot-v3/lib/console.c
===================================================================
--- coreboot-v3/lib/console.c 2008-09-04 00:38:54 UTC (rev 856)
+++ coreboot-v3/lib/console.c 2008-09-04 15:35:49 UTC (rev 857)
@@ -82,7 +82,9 @@
void printk_buffer_init(void)
{
- struct printk_buffer *buf = printk_buffer_addr();
+ struct printk_buffer *buf = (struct printk_buffer *)PRINTK_BUF_ADDR_CAR;
+ global_vars()->printk_buffer = buf;
+ buf = printk_buffer_addr();
buf->len = PRINTK_BUF_SIZE_CAR - sizeof(struct printk_buffer);
buf->readoffset = 0;
buf->writeoffset = 0;
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
