On 23/09/08 16:25 -0400, Ward Vandewege wrote: > On Mon, Sep 22, 2008 at 04:04:25PM -0600, Jordan Crouse wrote: > > The potential pitfalls for this patch are many, but I think the > > reward outweights the risk. > > > > The script will need the usual 0755 treatment. > > > > Jordan > > > > -- > > Jordan Crouse > > Systems Software Development Engineer > > Advanced Micro Devices, Inc. > > > > > > !DSPAM:48d8163d42417432833338! > > > buildrom: Add script to automatically pad ROMs > > > > Many ROMs may need to be padded before use. This script tries to do > > this somewhat automatically. If the platform needs the payload to be > > padded to a power of 2, then it should set PAYLOAD_DOPAD to '-p'. > > Otherwise, the script behaves as it normally does. > > > > Signed-off-by: Jordan Crouse <[EMAIL PROTECTED]> > > Acked-by: Ward Vandewege <[EMAIL PROTECTED]> > > It works unless the vga bios file is zero bytes long :)
Fixed - turns out that expr has a trick up its sleeve: Exit status is 0 if EXPRESSION is neither null nor 0, 1 if EXPRESSION is null or 0, 2 if EXPRESSION is syntactically invalid, and 3 if an error occurred bin/construct-rom.sh runs with -e, so thats your failure. I fixed it by oring the result of the expr with || true. r234. Thanks. buildrom should be completely dbm690t happy now, except for the vbios URL which is ongoing. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
