Carl-Daniel Hailfinger wrote: > New attempt with more cleanups and hopefully correct conversion:
Still not. I think this will be faster by hand. > +#define IO_LOCAL_INT(type, intr, apicid, pin) \ > +#define ISA_INT(intr, pin) \ ..maybe ISA_INT should also take apicid? > /* sata */ > - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW, > - 0, 18 << 2 | 0, apicid_sb600, 22); > + PCI_INT(0x0, 0x13, 0x0, 0x16); Problem here: 18 != 0x13 > - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW, > - bus_rs690[2], 0x0 << 2 | 0, apicid_sb600, 18); .. > - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW, > - bus_rs690[6], 0x0 << 2 | 0, apicid_sb600, 18); > + PCI_INT(bus_rs690[2], 0x0, 0x0, 0x13); > + PCI_INT(bus_rs690[6], 0x0, 0x0, 0x13); Again: 18 != 0x13 Fine otherwise. Fix the above and commit please. Acked-by: Peter Stuge <[EMAIL PROTECTED]> -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
