> On Mon, Oct 06, 2008 at 11:00:46PM +0200, [EMAIL PROTECTED] wrote: > > Whitespace fixes. > > Thanks for the cleanups! What are you using to fixup the code? Some > scripts or do you do it manually? I've noticed that you only fix > whitespace issues, and sometimes that's also fixed inconsistently.
Sorry about the inconsistencies. I mostly am comparing different versions of boards that I think should be similar, and trying to make them similar enough that a side-by-side diff shows me something besides white space differences. There are a lot of boards in v2 that have a lot of copy-and-paste goodness and badness. Anything besides white space cleanups have proven to be controversial in the past. I think most everyone has their own strongly-held opinions, and I'm not that opinionated on most of those issues, so I've steered clear. Thanks, Myles > Please consider basing the cleanups on the standard 'indent' options > as per http://www.coreboot.org/Development_Guidelines#Coding_Style. > That will also fix many other issues not related to indentation while > we're at it. > > indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs *.[ch] > > (will only work for C code, not Config.lb files, of course) > > But note that you should probably _not_ blindly commit 'indent'ed code, > it sometimes gets stuff wrong (which needs some manual fixing), and > some of the transformations (while correct) look a lot uglier > afterwards -- which I personally also fixup after running indent. > > > HTH, Uwe. > -- > http://www.hermann-uwe.de | http://www.holsham-traders.de > http://www.crazy-hacks.org | http://www.unmaintained-free-software.org > > -- > coreboot mailing list: [email protected] > http://www.coreboot.org/mailman/listinfo/coreboot -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
