On 07/10/08 02:45 +0200, Peter Stuge wrote: > Uwe Hermann wrote: > > Make the hardcoded "1" into a nice, descriptive #define? > .. > > Make the hardcoded "2" and "3" into nice, descriptive #defines? > > Also the 0x68 register could be a #define. > > I don't know. While they are good for documentation purposes they > cause a sometimes annyoing indirection when reading the code..
I'll add them - one one hand, nobody is going to learn how to program a HDA codec from reading the firwmare code - the firmware developers need to know that you read 0x68 and wait for bit 1 to clear and thats that. On the other hand, I admit that I had to look up the values here to see what is going on, so a little in code documentation by way of #define may be nicer to the next guy. I'll add the defines in the functions I hacked - I don't know nearly enough about how it all works to document the whole file. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
