On Thu, Oct 9, 2008 at 2:25 AM, Carl-Daniel Hailfinger
<[EMAIL PROTECTED]> wrote:

>>> -    if (!pci_conf1_find_device(0x1002,  0x4385, &dev)){
>>> +    if (!pci_conf1_find_device(PCI_VENDOR_ID_ATI,  0x4385, &dev)){
>>>
>>
>> Not sure about these at all. I think I prefer the number.
>>
>

if somebody someday put in 0x1003 for the vendor in that code, how
would you know it was wrong? Names are good :-)

ron

--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to