On Sat, Oct 11, 2008 at 12:42:43PM -0400, Corey Osgood wrote:
> Signed-off-by: Corey Osgood <[EMAIL PROTECTED]>
Acked-by: Uwe Hermann <[EMAIL PROTECTED]>
> Index: superio/fintek/f71805f/stage1.c
> ===================================================================
> --- superio/fintek/f71805f/stage1.c (revision 916)
> +++ superio/fintek/f71805f/stage1.c (working copy)
> @@ -1,7 +1,7 @@
> /*
> * This file is part of the coreboot project.
> *
> - * Copyright 2007 Corey Osgood <[EMAIL PROTECTED]>
> + * Copyright 2008 Corey Osgood <[EMAIL PROTECTED]>
Probably "2007-2008".
> -{
> - f71805f_rawpnp_enter_ext_func_mode(dev);
> - rawpnp_set_logical_device(dev, serial);
> + /* Serial port info from Kconfig (FTW!). Would be even more
> + * awesome if we could get 'dev' from Kconfig or dts */
> + /* TODO: Get/set serial port speed divisor from Kconfig as well */
> +#if defined (CONFIG_CONSOLE_SERIAL_COM1) && CONFIG_CONSOLE_SERIAL_COM1
> + serial_ldn = F71805F_COM1;
> + serial_iobase = 0x3f8;
> +#elif defined (CONFIG_CONSOLE_SERIAL_COM2) && CONFIG_CONSOLE_SERIAL_COM2
> + serial_ldn = F71805F_COM2;
> + serial_iobase = 0x2f8;
> +#else /* No serial console */
> + return;
> +#endif
OK for now, but maybe we can integrate this a bit more with the dts
later.
> static struct pnp_info pnp_dev_info[] = {
> - { &f71805f_ops, F71805F_SP1, PNP_IO0 | PNP_IRQ0, { 0x7f8, 0 }, },
> - { &f71805f_ops, F71805F_SP2, PNP_IO0 | PNP_IRQ0, { 0x7f8, 0 }, },
> + { &f71805f_ops, F71805F_COM1, PNP_IO0 | PNP_IRQ0, { 0x7f8, 0 }, },
> + { &f71805f_ops, F71805F_COM2, PNP_IO0 | PNP_IRQ0, { 0x7f8, 0 }, },
^^
one space only please
Uwe.
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
