Corey Osgood wrote: > u8 smbus_read_byte(u16 dimm, u8 offset, u16 smbus_io_base) .. > dimm = (dimm << 1) | 1; .. > With it, my spd addresses are 0x50, 0x51, etc, without it, they'd > be 0xa1, 0xa3, etc. Which would be preferred?
As others have said, the input to this function should be 0x50. > Do you think we'd ever need a 0xa0 or 0xa2 address? The bus just has 7 bits for address so no problem. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
