Marc Jones <[EMAIL PROTECTED]> writes:
> Arne Georg Gleditsch wrote:
>> Marc Jones <[EMAIL PROTECTED]> writes:
>>> This was my fault. I missed reviewing the abuild config.
>>>
>>> This is now the same as serengeti_cheetah_fam10.
>>>
>>> A little background information. The fam10 initialization is a bit
>>> larger than the K8 code. To make more room in the same 512K ROM that
>>> most platforms have the normal image was dropped. The other change is
>>> the use of failover. This makes the XIP CAR code live in only one
>>> place instead of in the fallback and normal images.
>>>
>>> Arne, please test a s2912_fam10 abuild and ack this.
>>
>> I'll do so. However, once I start digging into this -- would it make
>> sense to fix it properly so that the target builds a full 1024K ROM (as
>> the board is equipped with) and actually includes both the normal and
>> failover image?
>>
>
> Sure, That would be great.
Sorry about the delay, I was sidetracked by other stuff. Here's a patch
towards r3690 upping the ROM size for the S2912 Fam10 target to 1M.
Both regular and abuild images have been boot tested successfully. (Not
having a proper abuild infrastructure set up, the abuild image fails on
not having a real payload available, but otherwise looks correct.)
Signed-off-by: Arne Georg Gleditsch <[EMAIL PROTECTED]>
--
Arne.
diff --git a/src/mainboard/tyan/s2912_fam10/Config.lb b/src/mainboard/tyan/s2912_fam10/Config.lb
index 5af4ffb..91f0b1a 100644
--- a/src/mainboard/tyan/s2912_fam10/Config.lb
+++ b/src/mainboard/tyan/s2912_fam10/Config.lb
@@ -345,7 +345,7 @@ chip northbridge/amd/amdfam10/root_complex
device pci 6.0 on
chip drivers/pci/onboard
device pci 4.0 on end
- register "rom_address" = "0xfff80000"
+ register "rom_address" = "0xfff00000"
end
end # PCI
device pci 6.1 off end # AZA
diff --git a/src/mainboard/tyan/s2912_fam10/Options.lb b/src/mainboard/tyan/s2912_fam10/Options.lb
index 5e048a0..a0dacf6 100644
--- a/src/mainboard/tyan/s2912_fam10/Options.lb
+++ b/src/mainboard/tyan/s2912_fam10/Options.lb
@@ -126,7 +126,7 @@ uses AMD_UCODE_PATCH_FILE
##
## ROM_SIZE is the size of boot ROM that this board will use.
##
-default ROM_SIZE=524288
+default ROM_SIZE=1024*1024
#default ROM_SIZE=0x100000
##
@@ -135,9 +135,7 @@ default ROM_SIZE=524288
#default FALLBACK_SIZE=131072
#default FALLBACK_SIZE=0x40000
-#FALLBACK: ROM_SIZE-4K
-default FALLBACK_SIZE=ROM_SIZE-0x01000
-#FAILOVER: 4K
+default FALLBACK_SIZE=0x3f000
default FAILOVER_SIZE=0x01000
#more 1M for pgtbl
diff --git a/targets/tyan/s2912_fam10/Config-abuild.lb b/targets/tyan/s2912_fam10/Config-abuild.lb
index 9f3ae39..ed9ef2e 100644
--- a/targets/tyan/s2912_fam10/Config-abuild.lb
+++ b/targets/tyan/s2912_fam10/Config-abuild.lb
@@ -23,24 +23,30 @@ mainboard tyan/s2912_fam10
__COMPRESSION__
-option ROM_SIZE = 0x80000
-option FALLBACK_SIZE = 0x40000
-option FAILOVER_SIZE = 0x00
-
romimage "normal"
+ option USE_FAILOVER_IMAGE=0
option USE_FALLBACK_IMAGE=0
- option ROM_IMAGE_SIZE=0x24000
+ option ROM_IMAGE_SIZE=0x20000
option XIP_ROM_SIZE=0x40000
option COREBOOT_EXTRA_VERSION=".0-Normal"
payload __PAYLOAD__
end
romimage "fallback"
+ option USE_FAILOVER_IMAGE=0
option USE_FALLBACK_IMAGE=1
- option ROM_IMAGE_SIZE=0x24000
+ option ROM_IMAGE_SIZE=0x20000
option XIP_ROM_SIZE=0x40000
option COREBOOT_EXTRA_VERSION=".0-Fallback"
payload __PAYLOAD__
end
-buildrom ./coreboot.rom ROM_SIZE "normal" "fallback"
+romimage "failover"
+ option USE_FAILOVER_IMAGE=1
+ option USE_FALLBACK_IMAGE=0
+ option ROM_IMAGE_SIZE=FAILOVER_SIZE
+ option XIP_ROM_SIZE=FAILOVER_SIZE
+ option COREBOOT_EXTRA_VERSION=".0-Failover"
+end
+
+buildrom ./coreboot.rom ROM_SIZE "normal" "fallback" "failover"
diff --git a/targets/tyan/s2912_fam10/Config.lb b/targets/tyan/s2912_fam10/Config.lb
index 6400435..5c9dfcd 100644
--- a/targets/tyan/s2912_fam10/Config.lb
+++ b/targets/tyan/s2912_fam10/Config.lb
@@ -24,80 +24,27 @@
target s2912_fam10
mainboard tyan/s2912_fam10
-# This builds a fallback-only BIOS that fits in a 512K ROM. The S2912 onboard
-# flash is 1024K, so for use with that pad resulting ROM with 512KB lead-in.
+# Make room for ATI ES1000 VGA ROM
+option ROM_SIZE=ROM_SIZE-44*1024
-# Make room for ES1000 VGA ROM
-option ROM_SIZE=(512-44)*1024
-
-# serengeti_leopard
romimage "normal"
-# 48K for SCSI FW
-# option ROM_SIZE = 475136
-# 48K for SCSI FW and 48K for ATI ROM
-# option ROM_SIZE = 425984
-# 64K for Etherboot
-# option ROM_SIZE = 458752
-# 44k for atixx.rom
-# option ROM_SIZE = 479232
- option USE_FAILOVER_IMAGE=0
+ option USE_FAILOVER_IMAGE=0
option USE_FALLBACK_IMAGE=0
-# option ROM_IMAGE_SIZE=0x13800
-# option ROM_IMAGE_SIZE=0x18800
option ROM_IMAGE_SIZE=0x20000
-# option ROM_IMAGE_SIZE=0x15800
option XIP_ROM_SIZE=0x40000
option COREBOOT_EXTRA_VERSION="$(shell cat ../../VERSION)_Normal"
-# payload ../../../payloads/tg3--ide_disk.zelf
-# payload ../../../payloads/filo.elf
-# payload ../../../payloads/filo_mem.elf
-# payload ../../../payloads/filo.zelf
-# payload ../../../payloads/tg3--filo_hda2.zelf
-# payload ../../../payloads/tg3.zelf
-# payload ../../../../payloads/tg3_vga.zelf
-# payload ../../../../payloads/tg3--filo_hda2_vga.zelf
-# payload ../../../../payloads/tg3--filo_hda2_vga_5_4.zelf
-# payload ../../../../payloads/forcedeth--filo_hda2_vga.zelf
- payload ../../../../payloads/forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf
-# payload ../../../payloads/tg3_com2.zelf
-# payload ../../../payloads/e1000--filo.zelf
-# payload ../../../payloads/tg3--e1000--filo.zelf
-# payload ../../../payloads/tg3--eepro100--e1000--filo_hda2.zelf
-# payload ../../../payloads/tg3--eepro100--e1000--filo_hda2_5.3.zelf
-# payload ../../../payloads/tg3--eepro100--e1000--filo_hda2_com2.zelf
+# payload ../../../../payloads/forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf
+ payload ../payload.elf
end
romimage "fallback"
option USE_FAILOVER_IMAGE=0
option USE_FALLBACK_IMAGE=1
-# option ROM_IMAGE_SIZE=0x13800
-# option ROM_IMAGE_SIZE=0x19800
option ROM_IMAGE_SIZE=0x20000
-# option ROM_IMAGE_SIZE=0x15800
- option XIP_ROM_SIZE=0x20000
+ option XIP_ROM_SIZE=0x40000
option COREBOOT_EXTRA_VERSION="$(shell cat ../../VERSION)_Fallback"
-# payload ../../../payloads/tg3--ide_disk.zelf
-# payload ../../../payloads/filo.elf
-# payload ../../../payloads/filo_mem.elf
-# payload ../../../payloads/filo.zelf
-# payload ../../../payloads/tg3--filo_hda2.zelf
-# payload ../../../payloads/tg3.zelf
-# payload ../../../../payloads/tg3_vga.zelf
-# payload ../../../../payloads/memtest
-# payload ../../../../payloads/e1000_vga.zelf
-# payload ../../../../payloads/tg3--filo_hda2_vga.zelf
-# payload ../../../../payloads/filo_hda.zelf
-# payload ../../../../payloads/adlo.elf
-# payload ../../../../payloads/tg3--filo_hda2_vga_5_4.zelf
-# payload ../../../../payloads/forcedeth_mcp55_filo_hda2.zelf
- payload ../../../../payloads/forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf
-# payload ../../../../payloads/forcedeth--filo_hda2_vga.zelf
-# payload ../../../payloads/tg3_com2.zelf
-# payload ../../../payloads/e1000--filo.zelf
-# payload ../../../payloads/tg3--e1000--filo.zelf
-# payload ../../../payloads/tg3--eepro100--e1000--filo_hda2.zelf
-# payload ../../../payloads/tg3--eepro100--e1000--filo_hda2_5.3.zelf
-# payload ../../../payloads/tg3--eepro100--e1000--filo_hda2_com2.zelf
+# payload ../../../../payloads/forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf
+ payload ../payload.elf
end
romimage "failover"
@@ -108,5 +55,4 @@ romimage "failover"
option COREBOOT_EXTRA_VERSION="$(shell cat ../../VERSION)_Failover"
end
-#buildrom ./coreboot.rom ROM_SIZE "normal" "failover"
-buildrom ./coreboot.rom ROM_SIZE "fallback" "failover"
+buildrom ./coreboot.rom ROM_SIZE "normal" "fallback" "failover"
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
