on 20/10/2008 00:06 Uwe Hermann said the following: > On Fri, Oct 17, 2008 at 06:26:52PM +0300, Andriy Gapon wrote: >> Add register definitions for W83627HF based on publicly available >> specification and local testing. >> Also tweak a little bit algorithm for (internal) device id calculation: >> chips from W83627HF/F/HG/G family have id of 0x52 and a multitude of >> revisions (0x1x, 0x3A, 0x41, maybe more), chips from W83627HF/GF family >> have the same device id but revisions 0xFx. >> >> Signed-off-by: Andriy Gapon <[EMAIL PROTECTED]> > > Looks good, thanks! Committed in r3670.
Uwe, I've just noticed this and I apologize a lot: it seems that I used "W83627HF" and "W83627HF/GF" where I should have used "W83977EF" "W83977EF/EG" in the commit message above. Sorry for causing this confusions, maybe it's still possible to fix the commit message. It should have read: Add register definitions for W83977EF based on publicly available specification and local testing. Also tweak a little bit algorithm for (internal) device id calculation: chips from W83627HF/F/HG/G family have id of 0x52 and a multitude of revisions (0x1x, 0x3A, 0x41, maybe more), chips from W83977EF/EG family have the same device id but revisions 0xFx. Signed-off-by: Andriy Gapon <[EMAIL PROTECTED]> -- Andriy Gapon -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot

