On 28.10.2008 16:56, Idwer Vollering wrote: > 2008/10/28, Andriy Gapon <[EMAIL PROTECTED]>: > >> allow superiotool to compile and work on FreeBSD >> using the same approach as earlier flashrom port >> >> Signed-off-by: Andriy Gapon <[EMAIL PROTECTED]> >> >> --- >> >> This is tested on FreeBSD 7, dump for W83977EF/EG that I sent previously >> was obtained using this patch. >> >> It seems that this approach can also be extended to all coreboot (and >> utils) code that uses inX/outX (it is quite unfortunate that Linux and >> BSD use different order of parameters for outX). >> >> >> -- >> >> Andriy Gapon >> >> -- >> coreboot mailing list: [email protected] >> http://www.coreboot.org/mailman/listinfo/coreboot >> >> >> > Great ! However, you overlooked outb at lines 471 and 475 in ite.c, see my > patch. > > Idwer > >
With a signoff, you can take my Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
