On Mon, Nov 03, 2008 at 09:01:49AM -0700, Jordan Crouse wrote: > > However, I happened to notice that you also deleted all "Based on ..." > > lines and I'm a little bit unhappy about this. As I said in my last > > mail, I'd have liked to pay credit to the code that served me as > > example. ... Well, at least the SpaceRunner-LX patch is in now. ... > > I would actually prefer the "based on" syntax rather then retaining > the copyright notice, if you ask me. If you are just copying the same > API calls that all other motherboards use, then there is hardly anything > to copyright in the first place.
Full ACK. The only question here is whether this is the case for the cache_as_ram_auto.c file or not, but I'll leave that to you guys to judge. > Now, if there are some chunks of > unmodified code that are unique to the db800 code (such as a local function) > then thats a different story, but if you are just copying what everybody Yep. > else has done, retaining the copyright notice is silly and deleting the > "Based on" lines is double silly. I don't agree here (obviously). If we had added a "based on" line, every time someone cloned some other board in v2, we'd have files like this by now: /* * Based on the foo/bar target from vendor X. * Based on the foo/baz target from vendor Y. * Based on the foo/xxx target from vendor Z. * Based on the foo/yyy target from vendor A. * Based on the foo/zzz target from vendor B. * ... */ I'm _sure_ we can find code in v2 that has gone through more than 8 or 9 copy-paste iterations. Keeping adding "based on" lines just doesn't make much sense IMHO. Either way, this is not important enough to fuel a lenghty discussion, so here are two patches to fix it in either way, feel free to choose and apply one of them, whichever works better. Cheers, Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
Signed-off-by: Uwe Hermann <[EMAIL PROTECTED]> Index: src/mainboard/lippert/spacerunner-lx/Config.lb =================================================================== --- src/mainboard/lippert/spacerunner-lx/Config.lb (Revision 3729) +++ src/mainboard/lippert/spacerunner-lx/Config.lb (Arbeitskopie) @@ -18,6 +18,8 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +## Based on Config.lb from AMD's DB800 and DBM690T mainboards. + ## ## Compute the location and size of where this firmware image ## (coreboot plus bootloader) will live in the boot rom chip. Index: src/mainboard/lippert/spacerunner-lx/irq_tables.c =================================================================== --- src/mainboard/lippert/spacerunner-lx/irq_tables.c (Revision 3729) +++ src/mainboard/lippert/spacerunner-lx/irq_tables.c (Arbeitskopie) @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +/* Based on irq_tables.c from AMD's DB800 mainboard. */ + #include <arch/pirq_routing.h> #include <console/console.h> #include <arch/io.h> Index: src/mainboard/lippert/spacerunner-lx/Options.lb =================================================================== --- src/mainboard/lippert/spacerunner-lx/Options.lb (Revision 3729) +++ src/mainboard/lippert/spacerunner-lx/Options.lb (Arbeitskopie) @@ -18,6 +18,8 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +## Based on Options.lb from AMD's DB800 mainboard. + uses HAVE_MP_TABLE uses HAVE_PIRQ_TABLE uses USE_FALLBACK_IMAGE Index: src/mainboard/lippert/spacerunner-lx/chip.h =================================================================== --- src/mainboard/lippert/spacerunner-lx/chip.h (Revision 3729) +++ src/mainboard/lippert/spacerunner-lx/chip.h (Arbeitskopie) @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +/* Based on chip.h from AMD's DB800 mainboard. */ + #include <stdint.h> extern struct chip_operations mainboard_lippert_spacerunner_lx_ops; Index: src/mainboard/lippert/spacerunner-lx/mainboard.c =================================================================== --- src/mainboard/lippert/spacerunner-lx/mainboard.c (Revision 3729) +++ src/mainboard/lippert/spacerunner-lx/mainboard.c (Arbeitskopie) @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +/* Based on mainboard.c from AMD's DB800 mainboard. */ + #include <stdlib.h> #include <stdint.h> #include <console/console.h> Index: src/mainboard/lippert/spacerunner-lx/cache_as_ram_auto.c =================================================================== --- src/mainboard/lippert/spacerunner-lx/cache_as_ram_auto.c (Revision 3729) +++ src/mainboard/lippert/spacerunner-lx/cache_as_ram_auto.c (Arbeitskopie) @@ -19,6 +19,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +/* Based on cache_as_ram_auto.c from AMD's DB800 and DBM690T mainboards. */ + #define ASSEMBLY 1 #include <stdlib.h> Index: targets/lippert/spacerunner-lx/Config.lb =================================================================== --- targets/lippert/spacerunner-lx/Config.lb (Revision 3729) +++ targets/lippert/spacerunner-lx/Config.lb (Arbeitskopie) @@ -18,6 +18,8 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +## Based on Config.lb for the AMD Geode LX/5536 DB800 platform. + # Config file for the LiPPERT Cool SpaceRunner-LX. --JR 10/2008 target spacerunner-lx
Signed-off-by: Uwe Hermann <[EMAIL PROTECTED]> Index: src/mainboard/lippert/spacerunner-lx/cache_as_ram_auto.c =================================================================== --- src/mainboard/lippert/spacerunner-lx/cache_as_ram_auto.c (Revision 3729) +++ src/mainboard/lippert/spacerunner-lx/cache_as_ram_auto.c (Arbeitskopie) @@ -1,7 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2007 Advanced Micro Devices, Inc. * Copyright (C) 2008 LiPPERT Embedded Computers GmbH * * This program is free software; you can redistribute it and/or modify
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
