On Mon, Nov 10, 2008 at 06:21:16PM -0500, Corey Osgood wrote:
> On Mon, Nov 10, 2008 at 4:22 PM, Elia Yehuda <[EMAIL PROTECTED]> wrote:
>
> > The following patch fixes the 2 minute lag by marking out
> > the printk_debug() which tries to send information to the serial
> > console but it is not yet enabled - this should be done by another
> > patch...
> >
> > Signed-off-by: Elia Yehuda <[EMAIL PROTECTED]>
> >
>
> Why not just enable the serial console before enabling SMBus on your target?
Yep, we should do that.
Attached is a patch to fix all boards in v2 accordingly. I don't know if
all of them had that delay problem, but it's very likely...
Uwe.
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
Always enable serial before SMBus (or as early as possible), as the SMBus
enable may do printk()s which result in a 2 minute delay on some boards.
Fix this on all boards which currently do smbus_enable() before enabling
the serial console.
Signed-off-by: Uwe Hermann <[EMAIL PROTECTED]>
Index: src/mainboard/thomson/ip1000/auto.c
===================================================================
--- src/mainboard/thomson/ip1000/auto.c (Revision 3741)
+++ src/mainboard/thomson/ip1000/auto.c (Arbeitskopie)
@@ -101,13 +101,13 @@
hard_reset();
}
- enable_smbus();
-
smscsuperio_enable_serial(SERIAL_DEV, TTYS0_BASE);
mb_gpio_init();
uart_init();
console_init();
+ enable_smbus();
+
/* Prevent the TCO timer from rebooting us */
i82801xx_halt_tco_timer();
Index: src/mainboard/rca/rm4100/auto.c
===================================================================
--- src/mainboard/rca/rm4100/auto.c (Revision 3741)
+++ src/mainboard/rca/rm4100/auto.c (Arbeitskopie)
@@ -101,13 +101,13 @@
hard_reset();
}
- enable_smbus();
-
smscsuperio_enable_serial(SERIAL_DEV, TTYS0_BASE);
mb_gpio_init();
uart_init();
console_init();
+ enable_smbus();
+
/* Prevent the TCO timer from rebooting us */
i82801xx_halt_tco_timer();
Index: src/mainboard/via/epia-m/auto.c
===================================================================
--- src/mainboard/via/epia-m/auto.c (Revision 3741)
+++ src/mainboard/via/epia-m/auto.c (Arbeitskopie)
@@ -108,12 +108,12 @@
pci_write_config8(dev, 0x15, 0x1c);
}
- enable_smbus();
-
enable_vt8235_serial();
uart_init();
console_init();
+ enable_smbus();
+
print_spew("In auto.c:main()\r\n");
/* Halt if there was a built in self test failure */
Index: src/mainboard/msi/ms6178/auto.c
===================================================================
--- src/mainboard/msi/ms6178/auto.c (Revision 3741)
+++ src/mainboard/msi/ms6178/auto.c (Arbeitskopie)
@@ -53,8 +53,6 @@
if (bist == 0)
early_mtrr_init();
- enable_smbus();
-
/* FIXME */
outb(0x87, 0x2e);
outb(0x87, 0x2e);
@@ -64,6 +62,9 @@
uart_init();
console_init();
+
+ enable_smbus();
+
report_bist_failure(bist);
/* dump_spd_registers(&memctrl[0]); */
sdram_initialize(ARRAY_SIZE(memctrl), memctrl);
Index: src/mainboard/asus/mew-vm/auto.c
===================================================================
--- src/mainboard/asus/mew-vm/auto.c (Revision 3741)
+++ src/mainboard/asus/mew-vm/auto.c (Arbeitskopie)
@@ -66,12 +66,12 @@
if (bist == 0)
early_mtrr_init();
- enable_smbus();
-
lpc47b272_enable_serial(SERIAL_DEV, TTYS0_BASE);
uart_init();
console_init();
+ enable_smbus();
+
/* Halt if there was a built in self test failure. */
report_bist_failure(bist);
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
