Jordan Crouse wrote: > >C'mon, all I'm asking for is to put multiboot code into #if > >CONFIG_MULTIBOOT guards. If the plan is, however, to force everyone > >into multiboot, I suggest to drop the CONFIG_MULTIBOOT option > >completely. > > Changes made. Can I get a quick sanity check before committing? > > Signed-off-by: Robert Millan <[EMAIL PROTECTED]>
With the small change below it's Acked-by: Peter Stuge <[EMAIL PROTECTED]> > +++ src/arch/i386/boot/multiboot.c 2008-11-11 09:12:01.000000000 -0700 .. > +#if CONFIG_MULTIBOOT .. all of file .. > +#endif Please move this condition to Config.lb: > Index: src/arch/i386/boot/Config.lb > =================================================================== > --- src/arch/i386/boot/Config.lb.orig 2008-11-06 11:47:48.000000000 -0700 > +++ src/arch/i386/boot/Config.lb 2008-11-07 13:45:38.000000000 -0700 > @@ -3,6 +3,7 @@ > > object boot.o > object coreboot_table.o > +object multiboot.o > object tables.o > if HAVE_PIRQ_TABLE > object pirq_routing.o So that this becomes: object coreboot_table.o +if CONFIG_MULTIBOOT +object multiboot.o +end object tables.o //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
