Carl-Daniel Hailfinger wrote: > >> we want to keep Geode targets consistent. > > > > Says who? > > I say so and my clone agrees. ;-)
Well speak for yourself. :) I sure don't want to keep Geode targets consistent at all costs. I don't think that will be useful. > > If a board is unique and we can't abstract in general code then > > mainboard/ code is fine. > > If the abstraction works for all the other boards, there is no > reason to have different codebases except to confuse people who > want to port a new similar board. > > We have lots of places in v2 where people made some change to one > specific board, but the change would have applied to lots of > boards. In that case, please apply the change to more places. Better yet, move the common code out of board specific code. I promise to review and ack swiftly. > Later on, nobody could recall offhand why the files were different. Do you see this being a problem in this dual fake SPD and RAM chip case anytime soon? > To be honest, the amount of code duplication we have in v2 with > little arbitrary changes sprinkled all over the map is one of the > biggest reasons why I try to avoid v2 wherever possible. Cool. Feel free to help improve this in v3 by sending fixes when you identify possible improvements. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
