Re: [coreboot] [PATCH] v3: Add/use global PNP enter/exit functions forSuper I/Os

[Myles Watson]

> This is the start of a v3 superio refactoring, more will follow.
> Build-tested on one or two targets.

for fintek:
-static void pnp_enter_conf_state(struct device *dev)
-{
-       outb(0x87, dev->path.pnp.port);
-}

-       pnp_enter_conf_state(dev);
+       pnp_enter_8787(dev);

I don't know that much about SuperIOs, but does it matter that you replaced
one outb with two?

At least in pnp_enter_ite() it seems to matter.

Besides that it looks good.

Acked-by: Myles Watson <[EMAIL PROTECTED]>

Thanks,
Myles



--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot