> -----Original Message----- > From: Uwe Hermann [mailto:[EMAIL PROTECTED] > Sent: Tuesday, November 18, 2008 3:47 PM > To: Myles Watson > Cc: Coreboot > Subject: Re: [coreboot] subsystem IDs > > On Tue, Nov 18, 2008 at 02:49:37PM -0700, Myles Watson wrote: > > This patch makes subsystem ids work. Here are the changes by file: > > Nice! > > Acked-by: Uwe Hermann <[EMAIL PROTECTED]> > > So just to make sure -- we can now set per-board IDs _and_ override them > for individual PCI devices in the dts?
It should work. You should just have to add the subsystem values to the dts in the same way that it was added for the mainboard. You'll have to add them in the mainboard's dts, though, or override the function that sets it. If you add them in the device's dts they end up in the device_configuration structure. That's part of the reason why the superio code ended up the way it did. > > Index: mainboard/amd/serengeti/dts > > =================================================================== > > --- mainboard/amd/serengeti/dts (revision 1043) > > +++ mainboard/amd/serengeti/dts (working copy) > > @@ -22,6 +22,8 @@ > > device_operations="serengeti"; > > mainboard_vendor = "AMD"; > > mainboard_name = "Serengeti"; > > + subsystem_vendor = "PCI_VENDOR_ID_AMD"; > > Nice, I didn't know that #defines could be used in dts. Yeah. I like the dts. The strings from here go straight into statictree.c, so anything that compiles there is fine. Rev 1045. Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
