[EMAIL PROTECTED] wrote: > Author: mraudsepp > Date: 2008-11-20 13:20:35 +0100 (Thu, 20 Nov 2008) > New Revision: 1047 > > Modified: > coreboot-v3/lib/ramtest.c > Log: > Be silent in ram_check in non-debug loglevels > > As DBE61 support now runs ram_check for non-debug purposes and has expected > failures > on DBE61A, downgrade the per-address looped fail notification printk and > other messages > from BIOS_ERR to BIOS_DEBUG. >
This patch looks odd.
Why do you run the ram test at all if the debug level is below DEBUG, if
none of the results are printed? Arguing with the parsable return code
sounds a bit outrageous and would lead to see the same error printed
twice with BIOS_DEBUG level.
Wouldn't the right fix be to explicitly only check those areas that pass
are not "expected to fail"?
If RAM does not check, it's an error, not a debug message, and it should
be printed as BIOS_ERR.
If auto.c tries to check areas that are not checkable (ie vga memory),
that's a bug in auto.c and should be fixed there.
Stefan
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
signature.asc
Description: OpenPGP digital signature
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
