> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > On Behalf Of [EMAIL PROTECTED] > Sent: Thursday, November 20, 2008 12:26 PM > To: [email protected] > Subject: [coreboot] r3762 - trunk/coreboot-v2/src/mainboard/tyan/s2895 > > Author: stepan > Date: 2008-11-20 20:26:16 +0100 (Thu, 20 Nov 2008) > New Revision: 3762 > > Modified: > trunk/coreboot-v2/src/mainboard/tyan/s2895/cache_as_ram_auto.c > Log: > OK, people, watch this. > > This is a school book example of why trivial indent patches just suck > big time. > > This error was introduced by a trivial self-acked indent patch and was > never detected (because of a missing Config-abuild.lb) > > So, indenting the code for no reason can make it a lot worse (read: > break it) instead of improving it. > > I ask everyone to keep this in mind when going on indent-frenzy again.
Guilty. I apologize. Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
