On Tue, Nov 25, 2008 at 10:06 AM, ron minnich <[EMAIL PROTECTED]> wrote:
> On Tue, Nov 25, 2008 at 9:04 AM, Myles Watson <[EMAIL PROTECTED]> wrote: > > > I'm comfortable with the idea that this is the way we want to go, but it > > doesn't work for me yet. We could commit to make patching easier. I > guess > > it's up to you how functional you want it before committing. > > We'll commit when > 1. it works for you > 2. I can build a working dbe62 target (which I still can) > > You have the token for now. I'm not sure that's wise. I'm breaking more than fixing right now. Here's the latest snippet: DTC mainboard/amd/serengeti/dts (dts->lbh) name_node: [EMAIL PROTECTED],0(usb11) name_node: [EMAIL PROTECTED],1(usb12) name_node: [EMAIL PROTECTED],2(usb2) name_node: [EMAIL PROTECTED],0(nic) name_node: [EMAIL PROTECTED],0(multilevel_root) name_node: [EMAIL PROTECTED],0(lpc) name_node: [EMAIL PROTECTED],1(ide) name_node: [EMAIL PROTECTED],2(smbus) name_node: [EMAIL PROTECTED],3(acpi) name_node: [EMAIL PROTECTED],5(ac97audio) name_node: [EMAIL PROTECTED],6(ac97modem) name_node: [EMAIL PROTECTED],7(dev7) name_node: NULL(nic) name_node: NULL(ide) name_node: [EMAIL PROTECTED](NULL) name_node: NULL(lpc) fixup_properties: before fixups mainboard tree nic() NULL(nic) fixup_properties: before fixups chipnodes tree multilevel_root([EMAIL PROTECTED],0) [EMAIL PROTECTED],0(multilevel_root) [EMAIL PROTECTED],0(usb11) [EMAIL PROTECTED],1(usb12) [EMAIL PROTECTED],2(usb2) [EMAIL PROTECTED],0(nic) fixup_properties: checking nic() and multilevel_root([EMAIL PROTECTED],0) fixup_properties: checking nic() and lpc([EMAIL PROTECTED],0) fixup_properties: checking nic() and ide([EMAIL PROTECTED],1) fixup_properties: checking nic() and smbus([EMAIL PROTECTED],2) fixup_properties: checking nic() and acpi([EMAIL PROTECTED],3) fixup_properties: checking nic() and ac97audio([EMAIL PROTECTED],5) fixup_properties: checking nic() and ac97modem([EMAIL PROTECTED],6) fixup_properties: checking nic() and dev7([EMAIL PROTECTED],7) fixup_properties: checking nic() and nic() fixup_properties: last_child NULL() fixup_properties: matched and deleting nic((null)) del_node: matched and deleting nic((null)) del_node: expect seg fault nic((null)) /bin/sh: line 1: 3615 Segmentation fault /home/myles/buildrom/try/buildrom/buildrom-devel/work/coreboot-v3/svn/build/util/dtc/dtc -O lbh mainboard/amd/serengeti/dts >/tmp/statictree.h.$ make: *** [/home/myles/buildrom/try/buildrom/buildrom-devel/work/coreboot-v3/svn/build/statictree.h] Error 139 The "expect seg fault" line means that del_node got passed a node with no parent. That means I don't understand enough what's going on here. I was expecting the parent to be set to [EMAIL PROTECTED],0 (from the mainboard dts), but it hasn't been made yet (no name_node for it yet) Help me understand. Should we just take out the sibling links all together from del? Have they not been added yet? Thanks, Myles > > ron >
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
