See patch.

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED]  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

Patch to util/inteltool:
* Add support for i965, i975, ICH8M
* Add support for Darwin OS using DirectIO

This does not include additional changes from Lu Zhihe yet, I'll integrate them
in the next iteration.

Signed-off-by: Stefan Reinauer <[EMAIL PROTECTED]>

Index: gpio.c
===================================================================
--- gpio.c      (revision 3783)
+++ gpio.c      (working copy)
@@ -18,7 +18,6 @@
  */
 
 #include <stdio.h>
-#include <sys/io.h>
 #include "inteltool.h"
 
 static const io_register_t ich0_gpio_registers[] = {
@@ -78,6 +77,26 @@
        { 0x3C, 4, "RESERVED" }
 };
 
+static const io_register_t ich8_gpio_registers[] = {
+       { 0x00, 4, "GPIO_USE_SEL" },
+       { 0x04, 4, "GP_IO_SEL" },
+       { 0x08, 4, "RESERVED" },
+       { 0x0c, 4, "GP_LVL" },
+       { 0x10, 4, "GPIO_USE_SEL Override (LOW)" },
+       { 0x14, 4, "RESERVED" },
+       { 0x18, 4, "GPO_BLINK" },
+       { 0x1c, 4, "GP_SER_BLINK" },
+       { 0x20, 4, "GP_SB_CMDSTS" },
+       { 0x24, 4, "GP_SB_DATA" },
+       { 0x28, 4, "RESERVED" },
+       { 0x2c, 4, "GPI_INV" },
+       { 0x30, 4, "GPIO_USE_SEL2" },
+       { 0x34, 4, "GP_IO_SEL2" },
+       { 0x38, 4, "GP_LVL2" },
+       { 0x3C, 4, "GPIO_USE_SEL Override (HIGH)" }
+};
+
+
 int print_gpios(struct pci_dev *sb)
 {
        int i, size;
@@ -87,6 +106,11 @@
        printf("\n============= GPIOS =============\n\n");
 
        switch (sb->device_id) {
+       case PCI_DEVICE_ID_INTEL_ICH8M:
+               gpiobase = pci_read_word(sb, 0x48) & 0xfffc;
+               gpio_registers = ich8_gpio_registers;
+               size = ARRAY_SIZE(ich8_gpio_registers);
+               break;
        case PCI_DEVICE_ID_INTEL_ICH7:
        case PCI_DEVICE_ID_INTEL_ICH7M:
        case PCI_DEVICE_ID_INTEL_ICH7DH:
Index: inteltool.h
===================================================================
--- inteltool.h (revision 3783)
+++ inteltool.h (working copy)
@@ -18,6 +18,11 @@
  */
 
 #include <stdint.h>
+#ifndef DARWIN
+#include <sys/io.h>
+#else
+#include <DirectIO/darwinio.h>
+#endif
 #include <pci/pci.h>
 
 #define INTELTOOL_VERSION "1.0"
@@ -33,17 +38,23 @@
 #define PCI_DEVICE_ID_INTEL_ICH7       0x27b8
 #define PCI_DEVICE_ID_INTEL_ICH7M      0x27b9
 #define PCI_DEVICE_ID_INTEL_ICH7MDH    0x27bd
+#define PCI_DEVICE_ID_INTEL_ICH8M      0x2815
 
 #define PCI_DEVICE_ID_INTEL_82845      0x1a30
 #define PCI_DEVICE_ID_INTEL_82945P     0x2770
 #define PCI_DEVICE_ID_INTEL_82945GM    0x27a0
+#define PCI_DEVICE_ID_INTEL_PM965       0x2a00
+#define PCI_DEVICE_ID_INTEL_82975X      0x277c
 
 #define ARRAY_SIZE(a) ((int)(sizeof(a) / sizeof((a)[0])))
 
+#ifndef DARWIN
 typedef struct { uint32_t hi, lo; } msr_t;
+#endif
 typedef struct { uint16_t addr; int size; char *name; } io_register_t;
 
-extern int fd_mem;
+void *map_physical(unsigned long phys_addr, int len);
+void unmap_physical(void *virt_addr, int len);
 
 unsigned int cpuid(unsigned int op);
 int print_intel_core_msrs(void);
Index: pcie.c
===================================================================
--- pcie.c      (revision 3783)
+++ pcie.c      (working copy)
@@ -19,8 +19,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <sys/mman.h>
-
 #include "inteltool.h"
 
 /*
@@ -30,15 +28,20 @@
 {
        int i, size = (4 * 1024);
        volatile uint8_t *epbar;
-       uint32_t epbar_phys;
+       uint64_t epbar_phys;
 
        printf("\n============= EPBAR =============\n\n");
 
        switch (nb->device_id) {
        case PCI_DEVICE_ID_INTEL_82945GM:
        case PCI_DEVICE_ID_INTEL_82945P:
+       case PCI_DEVICE_ID_INTEL_82975X:
                epbar_phys = pci_read_long(nb, 0x40) & 0xfffffffe;
                break;
+       case PCI_DEVICE_ID_INTEL_PM965:
+               epbar_phys = pci_read_long(nb, 0x40) & 0xfffffffe;
+               epbar_phys |= ((uint64_t)pci_read_long(nb, 0x44)) << 32;
+               break;
        case 0x1234: // Dummy for non-existent functionality
                printf("This northbrigde does not have EPBAR.\n");
                return 1;
@@ -47,21 +50,20 @@
                return 1;
        }
 
-       epbar = mmap(0, size, PROT_WRITE | PROT_READ, MAP_SHARED,
-                    fd_mem, (off_t) epbar_phys);
+       epbar = map_physical(epbar_phys, size);
        
-       if (epbar == MAP_FAILED) {
+       if (epbar == NULL) {
                perror("Error mapping EPBAR");
                exit(1);
        }
 
-       printf("EPBAR = 0x%08x (MEM)\n\n", epbar_phys);
+       printf("EPBAR = 0x%08llx (MEM)\n\n", epbar_phys);
        for (i = 0; i < size; i += 4) {
                if (*(uint32_t *)(epbar + i))
                        printf("0x%04x: 0x%08x\n", i, *(uint32_t *)(epbar+i));
        }
 
-       munmap((void *)epbar, size);
+       unmap_physical((void *)epbar, size);
        return 0;
 }
 
@@ -72,15 +74,20 @@
 {
        int i, size = (4 * 1024);
        volatile uint8_t *dmibar;
-       uint32_t dmibar_phys;
+       uint64_t dmibar_phys;
 
        printf("\n============= DMIBAR ============\n\n");
 
        switch (nb->device_id) {
        case PCI_DEVICE_ID_INTEL_82945GM:
        case PCI_DEVICE_ID_INTEL_82945P:
+       case PCI_DEVICE_ID_INTEL_82975X:
                dmibar_phys = pci_read_long(nb, 0x4c) & 0xfffffffe;
                break;
+       case PCI_DEVICE_ID_INTEL_PM965:
+               dmibar_phys = pci_read_long(nb, 0x68) & 0xfffffffe;
+               dmibar_phys |= ((uint64_t)pci_read_long(nb, 0x6c)) << 32;
+               break;
        case 0x1234: // Dummy for non-existent functionality
                printf("This northbrigde does not have DMIBAR.\n");
                return 1;
@@ -89,21 +96,20 @@
                return 1;
        }
 
-       dmibar = mmap(0, size, PROT_WRITE | PROT_READ, MAP_SHARED,
-                     fd_mem, (off_t) dmibar_phys);
+       dmibar = map_physical(dmibar_phys, size);
        
-       if (dmibar == MAP_FAILED) {
+       if (dmibar == NULL) {
                perror("Error mapping DMIBAR");
                exit(1);
        }
 
-       printf("DMIBAR = 0x%08x (MEM)\n\n", dmibar_phys);
+       printf("DMIBAR = 0x%08llx (MEM)\n\n", dmibar_phys);
        for (i = 0; i < size; i += 4) {
                if (*(uint32_t *)(dmibar + i))
                        printf("0x%04x: 0x%08x\n", i, *(uint32_t *)(dmibar+i));
        }
 
-       munmap((void *)dmibar, size);
+       unmap_physical((void *)dmibar, size);
        return 0;
 }
 
@@ -112,8 +118,8 @@
  */
 int print_pciexbar(struct pci_dev *nb)
 {
-       uint32_t pciexbar_reg;
-       uint32_t pciexbar_phys;
+       uint64_t pciexbar_reg;
+       uint64_t pciexbar_phys;
        volatile uint8_t *pciexbar;
        int max_busses, devbase, i;
        int bus, dev, fn;
@@ -123,8 +129,13 @@
        switch (nb->device_id) {
        case PCI_DEVICE_ID_INTEL_82945GM:
        case PCI_DEVICE_ID_INTEL_82945P:
+       case PCI_DEVICE_ID_INTEL_82975X:
                pciexbar_reg = pci_read_long(nb, 0x48);
                break;
+       case PCI_DEVICE_ID_INTEL_PM965:
+               pciexbar_reg = pci_read_long(nb, 0x60);
+               pciexbar_reg |= ((uint64_t)pci_read_long(nb, 0x64)) << 32;
+               break;
        case 0x1234: // Dummy for non-existent functionality
                printf("Error: This northbrigde does not have PCIEXBAR.\n");
                return 1;
@@ -140,15 +151,15 @@
 
        switch ((pciexbar_reg >> 1) & 3) {
        case 0: // 256MB
-               pciexbar_phys = pciexbar_reg & ((1 << 31)|(1 << 30)|(1 << 
29)|(1 << 28));
+               pciexbar_phys = pciexbar_reg & (0xff << 28);
                max_busses = 256;
                break;
        case 1: // 128M
-               pciexbar_phys = pciexbar_reg & ((1 << 31)|(1 << 30)|(1 << 
29)|(1 << 28)|(1 << 27));
+               pciexbar_phys = pciexbar_reg & (0x1ff << 27);
                max_busses = 128;
                break;
        case 2: // 64M
-               pciexbar_phys = pciexbar_reg & ((1 << 31)|(1 << 30)|(1 << 
29)|(1 << 28)|(1 << 27)|(1 << 26));
+               pciexbar_phys = pciexbar_reg & (0x3ff << 26);
                max_busses = 64;
                break;
        default: // RSVD
@@ -156,12 +167,11 @@
                return 1;
        }       
 
-       printf("PCIEXBAR: 0x%08x\n", pciexbar_phys);
+       printf("PCIEXBAR: 0x%08llx\n", pciexbar_phys);
 
-       pciexbar = mmap(0, (max_busses * 1024 * 1024), PROT_WRITE | PROT_READ,
-                       MAP_SHARED, fd_mem, (off_t) pciexbar_phys);
+       pciexbar = map_physical(pciexbar_phys, (max_busses * 1024 * 1024));
        
-       if (pciexbar == MAP_FAILED) {
+       if (pciexbar == NULL) {
                perror("Error mapping PCIEXBAR");
                exit(1);
        }
@@ -194,7 +204,7 @@
                }
        }
 
-       munmap((void *)pciexbar, (max_busses * 1024 * 1024));
+       unmap_physical((void *)pciexbar, (max_busses * 1024 * 1024));
 
        return 0;
 }
Index: powermgt.c
===================================================================
--- powermgt.c  (revision 3783)
+++ powermgt.c  (working copy)
@@ -19,8 +19,6 @@
  */
 
 #include <stdio.h>
-#include <sys/io.h>
-
 #include "inteltool.h"
 
 int print_pmbase(struct pci_dev *sb)
@@ -35,6 +33,7 @@
        case PCI_DEVICE_ID_INTEL_ICH7M:
        case PCI_DEVICE_ID_INTEL_ICH7DH:
        case PCI_DEVICE_ID_INTEL_ICH7MDH:
+       case PCI_DEVICE_ID_INTEL_ICH8M:
                pmbase = pci_read_word(sb, 0x40) & 0xfffc;
                break;
        case 0x1234: // Dummy for non-existent functionality
@@ -48,6 +47,13 @@
        printf("PMBASE = 0x%04x (IO)\n\n", pmbase);
 
        for (i = 0; i < size; i += 4) {
+#ifdef DARWIN
+               if (i==0x14) {
+                       /* Reading this register will hang a macbook pro */
+                       printf("pmbase+0x%04x: 0xXXXXXXXX\n", i);
+                       continue;
+               }
+#endif
                printf("pmbase+0x%04x: 0x%08x\n", i, inl(pmbase + i));
        }
 
Index: cpu.c
===================================================================
--- cpu.c       (revision 3783)
+++ cpu.c       (working copy)
@@ -33,13 +33,18 @@
        unsigned int ret;
        unsigned int dummy2, dummy3, dummy4;
        asm volatile ( 
-               "cpuid" 
-               : "=a" (ret), "=b" (dummy2), "=c" (dummy3), "=d" (dummy4)
+               "pushl %%ebx    \n"
+               "cpuid          \n"
+               "movl %%ebx, %1 \n"
+               "popl %%ebx     \n"
+               : "=a" (ret), "=r" (dummy2), "=c" (dummy3), "=d" (dummy4)
                : "a" (op)
+               : "cc"
        );
        return ret;
 }
 
+#ifndef DARWIN
 int msr_readerror = 0;
 
 msr_t rdmsr(int addr)
@@ -72,6 +77,7 @@
 
        return msr;
 }
+#endif
 
 int print_intel_core_msrs(void)
 {
@@ -273,12 +279,14 @@
                return -1;
        }
 
+#ifndef DARWIN
        fd_msr = open("/dev/cpu/0/msr", O_RDWR);
        if (fd_msr < 0) {
                perror("Error while opening /dev/cpu/0/msr");
                printf("Did you run 'modprobe msr'?\n");
                return -1;
        }
+#endif
 
        printf("\n===================== SHARED MSRs (All Cores) 
=====================\n");
 
@@ -292,6 +300,7 @@
        close(fd_msr);
 
        for (core = 0; core < 8; core++) {
+#ifndef DARWIN
                char msrfilename[64];
                memset(msrfilename, 0, 64);
                sprintf(msrfilename, "/dev/cpu/%d/msr", core);
@@ -303,7 +312,7 @@
                 */
                if (fd_msr < 0)
                        break;
-
+#endif
                printf("\n====================== UNIQUE MSRs  (core %d) 
======================\n", core);
 
                for (i = 0; i < cpu->num_per_core_msrs; i++) {
@@ -312,13 +321,15 @@
                               cpu->per_core_msrs[i].number, msr.hi, msr.lo,
                               cpu->per_core_msrs[i].name);
                }
-
+#ifndef DARWIN
                close(fd_msr);
+#endif
        }
 
+#ifndef DARWIN
        if (msr_readerror)
                printf("\n(*) Some MSRs could not be read. The marked values 
are unreliable.\n");
-
+#endif
        return 0;
 }
 
Index: rootcmplx.c
===================================================================
--- rootcmplx.c (revision 3783)
+++ rootcmplx.c (working copy)
@@ -18,18 +18,8 @@
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-#include <errno.h>
-#include <fcntl.h>
-#include <unistd.h>
 #include <stdio.h>
-#include <string.h>
 #include <stdlib.h>
-#include <stdint.h>
-#include <getopt.h>
-#include <sys/mman.h>
-#include <sys/io.h>
-#include <pci/pci.h>
-
 #include "inteltool.h"
 
 int print_rcba(struct pci_dev *sb)
@@ -45,6 +35,7 @@
        case PCI_DEVICE_ID_INTEL_ICH7M:
        case PCI_DEVICE_ID_INTEL_ICH7DH:
        case PCI_DEVICE_ID_INTEL_ICH7MDH:
+       case PCI_DEVICE_ID_INTEL_ICH8M:
                rcba_phys = pci_read_long(sb, 0xf0) & 0xfffffffe;
                break;
        case PCI_DEVICE_ID_INTEL_ICH:
@@ -58,10 +49,9 @@
                return 1;
        }
 
-       rcba = mmap(0, size, PROT_WRITE | PROT_READ, MAP_SHARED,
-                   fd_mem, (off_t) rcba_phys);
+       rcba = map_physical(rcba_phys, size);
        
-       if (rcba == MAP_FAILED) {
+       if (rcba == NULL) {
                perror("Error mapping RCBA");
                exit(1);
        }
@@ -73,7 +63,7 @@
                        printf("0x%04x: 0x%08x\n", i, *(uint32_t *)(rcba + i));
        }
 
-       munmap((void *)rcba, size);
+       unmap_physical((void *)rcba, size);
        return 0;
 }
 
Index: memory.c
===================================================================
--- memory.c    (revision 3783)
+++ memory.c    (working copy)
@@ -20,8 +20,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <sys/mman.h>
-
 #include "inteltool.h"
 
 /*
@@ -31,15 +29,20 @@
 {
        int i, size = (16 * 1024);
        volatile uint8_t *mchbar;
-       uint32_t mchbar_phys;
+       uint64_t mchbar_phys;
 
        printf("\n============= MCHBAR ============\n\n");
 
        switch (nb->device_id) {
        case PCI_DEVICE_ID_INTEL_82945GM:
        case PCI_DEVICE_ID_INTEL_82945P:
+       case PCI_DEVICE_ID_INTEL_82975X:
                mchbar_phys = pci_read_long(nb, 0x44) & 0xfffffffe;
                break;
+       case PCI_DEVICE_ID_INTEL_PM965:
+               mchbar_phys = pci_read_long(nb, 0x48) & 0xfffffffe;
+               mchbar_phys |= ((uint64_t)pci_read_long(nb, 0x4c)) << 32;
+               break;
        case 0x1234: // Dummy for non-existent functionality
                printf("This northbrigde does not have MCHBAR.\n");
                return 1;
@@ -48,22 +51,21 @@
                return 1;
        }
 
-       mchbar = mmap(0, size, PROT_WRITE | PROT_READ, MAP_SHARED,
-                     fd_mem, (off_t) mchbar_phys);
+       mchbar = map_physical(mchbar_phys, size);
        
-       if (mchbar == MAP_FAILED) {
+       if (mchbar == NULL) {
                perror("Error mapping MCHBAR");
                exit(1);
        }
 
-       printf("MCHBAR = 0x%08x (MEM)\n\n", mchbar_phys);
+       printf("MCHBAR = 0x%08llx (MEM)\n\n", mchbar_phys);
 
        for (i = 0; i < size; i += 4) {
                if (*(uint32_t *)(mchbar + i))
                        printf("0x%04x: 0x%08x\n", i, *(uint32_t *)(mchbar+i));
        }
 
-       munmap((void *)mchbar, size);
+       unmap_physical((void *)mchbar, size);
        return 0;
 }
 
Index: inteltool.c
===================================================================
--- inteltool.c (revision 3783)
+++ inteltool.c (working copy)
@@ -21,9 +21,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <getopt.h>
-#include <sys/io.h>
 #include <fcntl.h>
-
+#include <sys/mman.h>
 #include "inteltool.h"
 
 static const struct {
@@ -33,6 +32,9 @@
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82845, "i845" },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82945P, "i945P" },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82945GM, "i945GM" },
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PM965, "PM965" },
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82975X, "i975X" },
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8M, "ICH8-M" },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7MDH, "ICH7-M DH" },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7M, "ICH7-M" },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7, "ICH7" },
@@ -44,8 +46,30 @@
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH, "ICH" }
 };
 
-int fd_mem;
+#ifndef DARWIN
+static int fd_mem;
 
+void *map_physical(unsigned long phys_addr, int len)
+{
+       void *virt_addr;
+
+       virt_addr = mmap(0, len, PROT_WRITE | PROT_READ, MAP_SHARED,
+                   fd_mem, (off_t) phys_addr);
+       
+       if (virt_addr == MAP_FAILED) {
+               printf("Error mapping physical memory 0x%08x[0x%x]\n", 
phys_addr, len);
+               return NULL;
+       }
+
+       return virt_addr;
+}
+
+void unmap_physical(void *virt_addr, int len)
+{
+       munmap((void *)rcba, size);
+}
+#endif
+
 void print_version(void)
 {
        printf("inteltool v%s -- ", INTELTOOL_VERSION);
@@ -164,10 +188,12 @@
                exit(1);
        }
 
+#ifndef DARWIN
        if ((fd_mem = open("/dev/mem", O_RDWR)) < 0) {
                perror("Can not open /dev/mem");
                exit(1);
        }
+#endif
 
        pacc = pci_alloc();
        pci_init(pacc);
Index: Makefile
===================================================================
--- Makefile    (revision 3783)
+++ Makefile    (working copy)
@@ -29,6 +29,13 @@
 
 OBJS = inteltool.o cpu.o gpio.o rootcmplx.o powermgt.o memory.o pcie.o
 
+OS_ARCH        = $(shell uname)
+ifeq ($(OS_ARCH), Darwin)
+CFLAGS += -DDARWIN -I/usr/local/include 
+LDFLAGS = -framework IOKit -framework DirectIO -L/usr/local/lib -lpci -lz
+# OBJS += darwinio.o
+endif
+
 all: pciutils dep $(PROGRAM)
 
 $(PROGRAM): $(OBJS)
@@ -41,10 +48,10 @@
        rm -f .dependencies
 
 dep:
-       @$(CC) -MM *.c > .dependencies
+       @$(CC) $(CFLAGS) -MM *.c > .dependencies
 
 pciutils:
-       @echo; echo -n "Checking for pciutils and zlib... "
+       @echo; /bin/echo -n "Checking for pciutils and zlib... "
        @$(shell ( echo "#include <pci/pci.h>";            \
                   echo "struct pci_access *pacc;";        \
                   echo "int main(int argc, char **argv)"; \
@@ -54,12 +61,12 @@
                echo "Please install pciutils-devel and zlib-devel.";   \
                echo "See README for more information."; echo;          \
                rm -f .test.c .test; exit 1)
-       @rm -f .test.c .test
+       @rm -rf .test.c .test .test.dSYM
 
 install: $(PROGRAM)
-       $(INSTALL) $(PROGRAM) $(PREFIX)/sbin
-       mkdir -p $(PREFIX)/share/man/man8
-       $(INSTALL) $(PROGRAM).8 $(PREFIX)/share/man/man8
+       $(INSTALL) $(PROGRAM) $(DESTDIR)$(PREFIX)/sbin
+       mkdir -p $(DESTDIR)$(PREFIX)/share/man/man8
+       $(INSTALL) $(PROGRAM).8 $(DESTDIR)$(PREFIX)/share/man/man8
 
 .PHONY: all clean distclean dep pciutils
 
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to