On Tue, Dec 2, 2008 at 11:34 AM, Jordan Crouse <[EMAIL PROTECTED]>wrote:
> Myles Watson wrote: > >> On Tue, Dec 2, 2008 at 9:45 AM, Jordan Crouse <[EMAIL PROTECTED] >> >wrote: >> >> If no .config exists, then default to qemu for defconfig targets. As a >>> further extension, I think we should consider allowing the user to pass >>> the >>> desired mainboard via an environment variable: >>> >>> make MAINBOARD=amd/db800 defconfig >>> >> >> >> I think we already do that. Here's the snippet from buildrom's >> packages/coreboot-v3/coreboot-v3.mk. >> >> @ make -C $(CBV3_SRC_DIR) defconfig \ >> MAINBOARDDIR="$(COREBOOT_VENDOR)/$(CBV3_BOARD)" \ >> > $(CBV3_CONFIG_LOG) 2>&1 >> >> Am I misunderstanding what you want to do? Did we used to allow that and >> it's broken since then? >> > > No, it still works. I guess thats fine - MAINBOARDDIR is slightly > unintuitive but we can deal. I guess we could add a MAINBOARD that gets copied into MAINBOARDDIR, or change all MAINBOARDDIR to MAINBOARD. I think that's a pretty trivial change if it only has to change in the Makefile. Your patch: Acked-by: Myles Watson <[EMAIL PROTECTED]> Thanks, Myles
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
