On 10.12.2008 12:08, Peter Stuge wrote: > Carl-Daniel Hailfinger wrote: > >> Flashrom assumes that the flash chip contents are available via >> mmap if no read function is defined. This special case is handled >> in lots of places all over the code. >> >> Remove the special case and supply a jedec_read function. >> > > This of course has absolutely nothing to do with JEDEC. > > I believe Stephan already created read_flash() in flashrom.c which > does exactly the same thing. Just use that. I've promised to attach > his patch to a ticket against the 1.1 milestone. >
Sorry, I don't understand completely. Was the read_flash() already merged or is it still to be merged? If it is the latter, I'd like to get it into 1.0. > Nak in short, at the very least the name and which file it's in is > all wrong. > What about calling it read_mmap()? Or maybe read_inband()? The general idea is to suggest that the flash does not need to execute a command to read (in the normal case). We could use a flashlib.c file to store such functions in. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
