On Mon, Dec 15, 2008 at 12:04 PM, Peter Stuge <[email protected]> wrote: > Peter Stuge wrote: >> FENG Yu Ning wrote: >> > * add a generic preop-opcode-pair table. >> > >> > * rename ich_check_opcodes to ich_init_opcodes. >> > >> > * let ich_init_opcodes do not need to access flashchip structure: >> > >> > . move the definition of struct preop_opcode_pair to a better place >> > . remove preop_opcode_pairs from 'struct flashchip' >> > . modify ich_init_opcodes and generate_opcodes so that they do not >> > access the >> > flashchip structure >> > >> > * call ich_init_opcodes during chipset enable. Now OPCODES generation >> > mechanism >> > works. >> > >> > * fix a coding style mistake. >> > >> > Signed-off-by: FENG yu ning <[email protected]> >> >> Committed in r3814.
Thanks for code reviewing and commitment. > And thank you so much for the great contribution to flashrom! :) I hope I will do more and do better ! yu ning -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
