Hi, i came across this error during YABEL debugging, and adding the expected values to me makes sense to really see that this is an error.
Cheers, Patty Signed-off-by: Pattrick Hueper <[email protected]> --- device/pci_rom.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/device/pci_rom.c b/device/pci_rom.c index 443f52b..75e08e4 100644 --- a/device/pci_rom.c +++ b/device/pci_rom.c @@ -113,8 +113,8 @@ struct rom_header *pci_rom_probe(struct device *dev) rom_data->vendor, rom_data->device); if (dev->id.pci.vendor != rom_data->vendor || dev->id.pci.device != rom_data->device) { printk(BIOS_ERR, - "Device or Vendor ID mismatch Vendor %04x, Device %04x\n", - rom_data->vendor, rom_data->device); + "Device or Vendor ID mismatch Vendor %04x, Device %04x, expected: Vendor: %04x, Device %04x\n", + rom_data->vendor, rom_data->device, dev->id.pci.vendor, dev->id.pci.device); return NULL; }
From 0b3ff564413b45645488594126ea22cf6b5accb9 Mon Sep 17 00:00:00 2001 From: Pattrick Hueper <[email protected]> Date: Tue, 16 Dec 2008 10:25:54 +0100 Subject: [PATCH 1/3] enhance error output if ROM Vendor/Device and PCI Vendor/Device do not match Signed-off-by: Pattrick Hueper <[email protected]> --- device/pci_rom.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/device/pci_rom.c b/device/pci_rom.c index 443f52b..75e08e4 100644 --- a/device/pci_rom.c +++ b/device/pci_rom.c @@ -113,8 +113,8 @@ struct rom_header *pci_rom_probe(struct device *dev) rom_data->vendor, rom_data->device); if (dev->id.pci.vendor != rom_data->vendor || dev->id.pci.device != rom_data->device) { printk(BIOS_ERR, - "Device or Vendor ID mismatch Vendor %04x, Device %04x\n", - rom_data->vendor, rom_data->device); + "Device or Vendor ID mismatch Vendor %04x, Device %04x, expected: Vendor: %04x, Device %04x\n", + rom_data->vendor, rom_data->device, dev->id.pci.vendor, dev->id.pci.device); return NULL; } -- 1.6.0.4
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
