On 29.12.2008 07:28, Bao, Zheng wrote: > It seems to be a resolution before we can finally get the reason why > hardware behaves strange. > > Please replace the multiple spaces with tab before checking in. >
Sure. > Acked-by: Zheng Bao <[email protected]> > Thanks, committed in revision 3845. Regards, Carl-Daniel > -----Original Message----- > From: Carl-Daniel Hailfinger [mailto:[email protected]] > Sent: Monday, December 29, 2008 10:48 AM > To: Bao, Zheng > Cc: Coreboot > Subject: Re: [coreboot] [PATCH] Fix SB600 SATA and add support for port > 2-4 > > Hi Zheng, > > On 25.12.2008 05:10, Bao, Zheng wrote: > >> On 24.12.2008 16:00, Carl-Daniel Hailfinger wrote: >> >> >> >>> On 23.12.2008 08:10, Bao, Zheng wrote: >>> >>>> Sorry, I tested it again and tried it on 4 ports. It only works on 1st >>>> and 4th ports, while doesn't work on 2nd and 3rd ports. It loops at >>>> driver no longer selected after 10ms, retrying init >>>> driver no longer selected after 10ms, retrying init >>>> >>>> >>>> My SATA drive is 250 GB Seagate Barracuda ST3250620NS. >>>> >>>> >>> Thanks for testing! >>> This is very strange. It seems the hardware does not follow the BDG. >>> Did you have 4 drives attached at the same time or was it 1 drive attached >>> to another port each time? >>> >> What you said reminded me to connect more drives when the board boots. >> Yes, it changed. If 1st and 2nd ports are both connected, they can >> both be >> correctly detected and initialized. Then I unplugged the drive on 1st >> post and didn't change the BIOS, the 2nd ports couldn't be initialized >> as it was. I check our asm code and can't find any tip. >> >> > > I have modified the code to avoid the endless loop and print better > diagnostic messages. > It will work if only 1st or if 1st and 2nd port are connected. If only > 2nd is connected and the hardware acts strange, it will print an error > message and continue. > I have not tested 3rd and 4th port. > > Can you please test if this works for you? > > Signed-off-by: Carl-Daniel Hailfinger > <[email protected]> -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
