On Mon, Jan 05, 2009 at 02:47:15AM +0100, Carl-Daniel Hailfinger wrote:
> The flashrom man page has incomplete author/copyright sections and an
> incorrect license section.
> - Remove the copyright listings and refer the reader to the source files.

ACK, this is a pita to keep up-to-date in many places (README, manpage,
wiki, source, whatever). The only authoritative place for (C) lines is
(and should be) the source code.


> - Update the author list to those which have copyright messages in the
> source files.
> - Correct the license from GPL v2+ to GPL v2.

That's not quite correct / complete. I'd use a text such as this:

Flashrom is licensed under the terms of the GNU General Public License (GPL).
Some files are licensed under the "GPL (version 2, or any later version)",
and some files are licensed under the "GPL, version 2".


> Signed-off-by: Carl-Daniel Hailfinger <[email protected]>
> 
> Index: flashrom-manpage/flashrom.8
> ===================================================================
> --- flashrom-manpage/flashrom.8       (Revision 3811)
> +++ flashrom-manpage/flashrom.8       (Arbeitskopie)
> @@ -1,4 +1,4 @@
> -.TH FLASHROM 8 "June 22, 2008"
> +.TH FLASHROM 8 "January 5, 2009"
>  .SH NAME
>  flashrom \- a universal BIOS/ROM/flash programming utility
>  .SH SYNOPSIS
> @@ -84,22 +84,51 @@
>  .RB "(" http://coreboot.org/Mailinglist ")."
>  .SH LICENCE
>  .B flashrom
> -is covered by the GNU General Public License (GPL), version 2 or later.
> +is covered by the GNU General Public License (GPL), version 2.
>  .SH COPYRIGHT
> -2000 Silicon Integrated System Corporation
>  .br
> -2003 Niki W. Waibel
> -.br
> -2004 Tyan Corp
> -.br
> -2005-2007 coresystems GmbH
> +Please see the individual files.
>  .SH AUTHORS
>  Yinghai Lu <[email protected]>
>  .br
>  Stefan Reinauer <[email protected]>
>  .br
> -Niki W. Waibel <[email protected]>
> +Ronald G. Minnich <[email protected]>
>  .br
> +Steven James <[email protected]>
> +.br
> +Giampiero Giancipoli <[email protected]>
> +.br
> +Uwe Hermann <[email protected]>
> +.br

> +2008 Carl-Daniel Hailfinger

Drop this...


> +.br
> +Luc Verhaegen <[email protected]>
> +.br
> +Carl-Daniel Hailfinger

... as this line is also there.


Also, are the entries in some order? Maybe sort alphabetically? This is
what we do in superiotool, I think.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to