On Wed, Jan 7, 2009 at 10:42 AM, Myles Watson <[email protected]> wrote: > On Wed, Jan 7, 2009 at 10:29 AM, Peter Stuge <[email protected]> wrote:
>> I suggest moving VSA init to domain.phase1. It's certainly very early >> setup because it _creates_ the PCI devices that are to be fixed up in >> phase2. > If phase1 is really obsolete, then phase2 is as early as you get. Do > we need to reinstate phase1? Being the top level of the Geode PCI domain, Phase2_fixup for the domain in parent to child order is correct place to do VSA init. Phase2_fixup for the cs5536 southbridge should make the NAND/IDE switch before resource allocation in phase 3-5. I think that you want phase6 to walk the tree in case there is something that needs fixup after allocation especially if it was hidden from allocation. Marc -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot

