Author: myles Date: 2009-01-07 19:37:21 +0100 (Wed, 07 Jan 2009) New Revision: 1104
Modified: coreboot-v3/southbridge/nvidia/ck804/ck804_nic.c coreboot-v3/southbridge/nvidia/ck804/lpc.c Log: This trivial patch adds the warnings Peter and Ron requested to the ck804 code. Signed-off-by: Myles Watson <[email protected]> Acked-by: Myles Watson <[email protected]> Modified: coreboot-v3/southbridge/nvidia/ck804/ck804_nic.c =================================================================== --- coreboot-v3/southbridge/nvidia/ck804/ck804_nic.c 2009-01-07 18:26:18 UTC (rev 1103) +++ coreboot-v3/southbridge/nvidia/ck804/ck804_nic.c 2009-01-07 18:37:21 UTC (rev 1104) @@ -89,6 +89,8 @@ } } +#warning This should be fixed. Can we use a LAR file for the MAC? + /* If that is invalid we will read that from romstrap. */ if (!eeprom_valid) { unsigned long mac_pos; Modified: coreboot-v3/southbridge/nvidia/ck804/lpc.c =================================================================== --- coreboot-v3/southbridge/nvidia/ck804/lpc.c 2009-01-07 18:26:18 UTC (rev 1103) +++ coreboot-v3/southbridge/nvidia/ck804/lpc.c 2009-01-07 18:37:21 UTC (rev 1104) @@ -124,6 +124,8 @@ #define SLOW_CPU_OFF 0 #define SLOW_CPU__ON 1 +#warning Power on after fail should be a CMOS option. + #ifndef MAINBOARD_POWER_ON_AFTER_POWER_FAIL #define MAINBOARD_POWER_ON_AFTER_POWER_FAIL MAINBOARD_POWER_ON #endif -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
