Ühel kenal päeval, R, 2009-01-09 kell 15:32, kirjutas Peter Stuge: > Mart Raudsepp wrote: > > cs5536: Remove redundant enable_ide variable from ide device. > > Patch itself is clean, but I don't know if it is desirable to change > the behavior this way. I could ack but I am not 100% sure about the > disabling/enabling stuff - I remember a lot of discussion about it > but I don't remember the outcome. :\
The controversial part is about such a variable in the southbridge parent device that would select ide or nand. E.g what sb->enable_ide_nand_flash kind of is right now - zero means IDE and non-zero means Flash in a given chip select. I haven't gotten around to investigating if that chip select and its setup can be moved to the newly created NAND device or not - once I do that "controversy" will arise. The ide->enable_ide statictree struct member that this patch kills just duplicates existing ide->enabled struct member. > Will a dts expert please chime in? That'd be appreciated Mart Raudsepp -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
