On 14.01.2009 00:55, Stefan Reinauer wrote: > On 14.01.2009 0:33 Uhr, Peter Stuge wrote: > >> ron minnich wrote: >> >> >>>>> Similarly to flashchips array, this patch intends to make the >>>>> table board_pciid_enables more readable. >>>>> >>>>> >>>> For certain versions of readable. What real problem does this solve? >>>> >>>> >>> 1. Next time someone adds a new struct member, we avoid mistakes of >>> ordering of initializers >>> 2. we avoid mistakes in the first place. >>> >>> The .x = y stuff was added for a (good) reason, I think this is an >>> improvement. >>> >>> Acked-by: Ronald G. Minnich <[email protected]> >>> >>> >> Sorry, but I really do not like these at all and I would much rather >> see the chip table change back. There seemed to be general agreement >> about that on IRC the other day as well. >> >> > Why? >
I was unaware of the general agreement on IRC although I was there. The current table is horrible. Two lines per entry combine the worst of both worlds. And since I edit the wrong line every single time I touch that array, the patch is Acked-by: Carl-Daniel Hailfinger <[email protected]> Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
