On 06.01.2009 01:03, Uwe Hermann wrote: > On Mon, Jan 05, 2009 at 02:03:04PM +0100, Carl-Daniel Hailfinger wrote: > >> Check the printk format string against the matching arguments. We have >> this type of checking in the v3 code since ages, but v2 will happily >> compile any code with bogus printk format strings and/or parameters. >> This can cause real bugs and at least needs to emit a warning, if not an >> error. Go with a warning for now since most of the flagged format >> strings are wrong but harmless in a 32-bit x86 environment. >> > [...] > >> Signed-off-by: Carl-Daniel Hailfinger <[email protected]> >> > > If this is abuild-tested, it's: > > Acked-by: Uwe Hermann <[email protected]> > > (Please make sure we don't get some romcc compile trouble because of > the __attribute__) >
Thanks, abuild-tested and committed in r3872. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
