On Thu, 2009-02-12 at 15:29 -0700, Myles Watson wrote: > On Thu, Feb 12, 2009 at 3:16 PM, Ronald Hoogenboom <[email protected]> wrote: > > On Thu, 2009-02-12 at 14:44 -0700, Myles Watson wrote: > >> On Thu, Feb 12, 2009 at 2:29 PM, ron minnich <[email protected]> wrote: > >> > On Thu, Feb 12, 2009 at 1:28 PM, Myles Watson <[email protected]> wrote: > >> >> On Thu, Feb 12, 2009 at 2:19 PM, Ronald Hoogenboom <[email protected]> > >> >> wrote: > >> >>> Hi, > >> >>> > >> >>> After updating to r1129, adds call to allow_all_aps_stop to initram.c, > >> >>> bootblock is too big (16 bytes) and build fails. (gigabyte m57sli) > >> >> > >> >> Did we ever decide on how big was too big for the bootblock? I > >> >> thought it was clear that we needed it to be larger for k8. Should we > >> >> make it a parameter? I realize it's hardcoded in lar right now. > >> >> > >> > > >> > it's really hardcoded in a few places. > >> > >> So he should just take out a few printk statements to make it fit again? > >> > >> Thanks, > >> Myles > > Sorry, its not the addition to initram.c, but the extra stuff in > > arch/x86/amd/stage0.S that makes it too big. No printk in there... > > You're right :) I spoke too quickly. > > Thanks, > Myles [coreboot-v3]$ objdump -t build/stage0-prefixed.o | awk '/\.c$/{print $6}' | sort -u stage0_clog2.c stage0_console.c stage0_delay.c stage0_dualcore_id.c stage0_get_nodes.c stage0_incoherent_ht_chain.c stage0_lar.c stage0_libstage1.c stage0_lzma.c stage0_mc146818rtc.c stage0_mem.c stage0_option_table.c stage0_pci_ops_conf1.c stage0_pnp_raw.c stage0_post_code.c stage0_resourcemap.c stage0_serial.c stage0_stage1.c stage0_stage1_enable_rom.c stage0_stage1_mtrr.c stage0_stage1_smbus.c stage0_string.c stage0_uart8250.c stage0_udelay_io.c stage0_vsprintf.c stage0_vtxprintf.c
Is ALL this stuff actually needed in stage0??? -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot

