On Wed, Mar 18, 2009 at 12:17 PM, Myles Watson <[email protected]> wrote:
> On Tue, Mar 17, 2009 at 3:27 PM, Myles Watson <[email protected]> wrote:
>> I have two coreboot trees.  As far as I can tell they're identical.
>> One produces working ROM images, and the other reboots when it jumps
>> to the payload.
>
> That was the key.  I hadn't done a make clean in the working tree.
> Rev 4000 broke it for me, but I'm still not sure why.  Once I was
> doing make clean every time I could find the revision that was
> breaking.  It looks like Rev 4000 changed the compile flags, so that's
> where I'm going next.  Everything else in 4000 looks innocuous to me.

The question is why these compiler flags for coreboot make SeaBIOS
panic.  I'm still trying to narrow it down, but if you spot it first
that would be great!

Thanks,
Myles

Modified: trunk/coreboot-v2/src/config/Config.lb
===================================================================
--- trunk/coreboot-v2/src/config/Config.lb      2009-03-13 00:44:09
UTC (rev 3999)
+++ trunk/coreboot-v2/src/config/Config.lb      2009-03-13 15:42:27
UTC (rev 4000)
@@ -10,7 +10,7 @@
 makedefine GCC_INC_DIR := $(shell LC_ALL=C $(GCC) -print-search-dirs
| sed -ne "s/install: \(.*\)/\1include/gp")

 makedefine CPPFLAGS := -I$(TOP)/src/include
-I$(TOP)/src/arch/$(ARCH)/include -I$(GCC_INC_DIR) $(CPUFLAGS)
-makedefine CFLAGS := $(CPU_OPT) $(DISTRO_CFLAGS) $(CPPFLAGS) -Os
-nostdinc -nostdlib -fno-builtin  -Wall
+makedefine CFLAGS := $(CPU_OPT) $(DISTRO_CFLAGS) $(CPPFLAGS) -Os
-nostdinc -nostdlib -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs
-Werror-implicit-function-declaration -Wstrict-aliasing -Wshadow
-fno-common -ffreestanding -fno-builtin -fomit-frame-pointer

 if ASSEMBLER_DEBUG
 makedefine DEBUG_CFLAGS := -g -dA -fverbose-asm

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to