On Mon, Apr 13, 2009 at 9:12 AM, Ronald Hoogenboom <[email protected]> wrote: > Hi, > > There is a typo in amdk8/raminit_f.c regarding the preprocessor symbol > QRANK_DIMM_SUPPORT in line 2208, which caused the protected code > fragment never to be included for compilation. > I guessed what the dimm_mask and sz.rank should have been (I'm not > familiar with the functionality of this piece of code). > > > Please review, anyone who is familiar (yhlu/mjones?). > > Signed-off-by: Ronald Hoogenboom <[email protected]>
Did you find this on a qrank setup or just visual inspection? You fix looks correct. Acked-by: Marc Jones <[email protected]> Marc -- http://marcjonesconsulting.com -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
