On 20.04.2009 14:45, Peter Stuge wrote: > Luc Verhaegen wrote: > >> This patch restores the pciid based board matching table. It makes this >> table readable and hackable again, and the only disadvantage is that the >> right margin is way beyond the rather dogmatic 80. All 0x0000 pci ids have >> been string replaced by 0 to more easily spot missing ids, and extra >> comments have been added to explain how the various entries are used. >> >> Signed-Off-By: Luc Verhaegen <[email protected]> >> > > Thanks! r4142. > > > Carl-Daniel Hailfinger wrote: > >> The documentation part can be committed after one more iteration. >> > > I took the liberty of improving the wording a little. >
Thanks. >> The rest of the patch makes board entries unreadable. >> > > I disagree very much, and I welcome this patch because I naked the > original change. > Should I now revert the table part of the patch because I nak it and the original conversion to multiline had more acks than the conversion back to single-line? Sorry, but this is just silly. The table part of the patch was certainly not 1.0 material. Is there any reason to hold off committing my own non-1.0 patches? Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
