On Tue, Apr 28, 2009 at 7:14 AM, Stefan Reinauer <[email protected]> wrote: > On 28.04.2009 15:04 Uhr, Myles Watson wrote: > > On Tue, Apr 28, 2009 at 7:00 AM, Patrick Georgi <[email protected]> > wrote: > > > Am 28.04.2009 14:39, schrieb Stefan Reinauer: > > > Wonderful! This is much better. Can we enable HAVE_HIGH_TABLES for all > amdk8 boards now? > > > for i in \ > `grep "northbridge/amd/amdk8" src/mainboard/*/*/Config.lb|\ > cut -d: -f1 |sort -u`; do > grep -L HAVE_HIGH_TABLES `dirname $i`/Options.lb > done > > claims the following boards are amdk8 (whose northbridge code is high tables > equipped) without HAVE_HIGH_TABLES: > > src/mainboard/amd/dbm690t/Options.lb > src/mainboard/amd/pistachio/Options.lb > src/mainboard/amd/serengeti_cheetah/Options.lb > src/mainboard/amd/serengeti_cheetah_fam10/Options.lb > src/mainboard/arima/hdama/Options.lb > src/mainboard/asus/a8n_e/Options.lb > src/mainboard/asus/a8v-e_se/Options.lb > src/mainboard/broadcom/blast/Options.lb > src/mainboard/gigabyte/ga_2761gxdk/Options.lb > src/mainboard/gigabyte/m57sli/Options.lb > src/mainboard/hp/dl145_g3/Options.lb > src/mainboard/ibm/e325/Options.lb > src/mainboard/ibm/e326/Options.lb > src/mainboard/iwill/dk8_htx/Options.lb > src/mainboard/iwill/dk8s2/Options.lb > src/mainboard/iwill/dk8x/Options.lb > src/mainboard/msi/ms7135/Options.lb > src/mainboard/msi/ms7260/Options.lb > src/mainboard/msi/ms9185/Options.lb > src/mainboard/msi/ms9282/Options.lb > src/mainboard/newisys/khepri/Options.lb > src/mainboard/nvidia/l1_2pvv/Options.lb > src/mainboard/sunw/ultra40/Options.lb > src/mainboard/supermicro/h8dmr/Options.lb > src/mainboard/technexion/tim8690/Options.lb > src/mainboard/tyan/s2850/Options.lb > src/mainboard/tyan/s2875/Options.lb > src/mainboard/tyan/s2880/Options.lb > src/mainboard/tyan/s2881/Options.lb > src/mainboard/tyan/s2882/Options.lb > src/mainboard/tyan/s2885/Options.lb > src/mainboard/tyan/s2912/Options.lb > src/mainboard/tyan/s4880/Options.lb > src/mainboard/tyan/s4882/Options.lb > > anyone willing to convert them? > > > Will this do? > > Index: src/northbridge/amd/amdk8/Config.lb > =================================================================== > --- src/northbridge/amd/amdk8/Config.lb (revision 1595) > +++ src/northbridge/amd/amdk8/Config.lb (working copy) > @@ -1,7 +1,9 @@ > uses AGP_APERTURE_SIZE > uses HAVE_ACPI_TABLES > +uses HAVE_HIGH_TABLES > > default AGP_APERTURE_SIZE=0x4000000 > +default HAVE_HIGH_TABLES=1 > > config chip.h
Good point. I think you're right that this should be sufficient. This is probably also the place to migrate a lot of the uses statements that are K8-specific. Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
