> -----Original Message----- > From: [email protected] [mailto:[email protected]] > On Behalf Of Peter Stuge > Sent: Thursday, April 30, 2009 6:29 PM > To: [email protected] > Subject: Re: [coreboot] [PATCH] Remove warnings for s2892 > > Myles Watson wrote: > > > This does not look right to me. I think the good fix is to not rename > > > things but only remove the u8 (re)declaration on line 115. > > > > I didn't do that because it would change the behavior and I wouldn't > > be able to tell breakage by building. I don't know enough about > > keyboard controllers to test this part of the code. > > The semantics of the changed code are pretty simple and looking at > other parts of the same file shows that it is a common construct. > > It's used to retry keyboard communication a few times in case the > keyboard is slow or just generally crappy. > > If you make a patch it is > > Acked-by: Peter Stuge <[email protected]> Rev 4241.
Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
