On 06.05.2009 15:52, Peter Stuge wrote: > Carl-Daniel Hailfinger wrote: > >> Improve SST25 status register routines: >> - Using a 4-bit index into an array with 8 elements leads to >> out-of-bounds accesses. That bug was introduced by a self-acked patch >> from someone. Use proper bit masking to fix this. >> > > I think it's pointless to write "it was introduced by self-ack" at > all if you do not also write who it was. Either go all the way and > actually blame someone because you think it's a big deal or don't > bother because it's just about _one bit_.
It's one bit which can cause segfaults. I know who did it (svn blame helps), but I will NOT mention names in public. That would be bad style. > It takes more effort to > read the english text than to go with the patch. > > My point; Some bugs warrant discussion, others maybe not as much. > Anyway, I removed the part about the self-ack from the changelog. >> Signed-off-by: Carl-Daniel Hailfinger <[email protected]> >> > > Acked-by: Peter Stuge <[email protected]> > Thanks, r468. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
