On 08.05.2009 13:57, Uwe Hermann wrote: > On Fri, May 08, 2009 at 03:04:18AM +0200, Carl-Daniel Hailfinger wrote: > >> Flashrom assumes that the flash chip contents are available via mmap if >> no read function is defined. This special case is handled in lots of >> places all over the code. >> >> Remove the special case and use the read_memmapped function. Not only >> does this allow us to fix a read bug in flashrom I recently uncovered on >> ICH SPI, it also allows us to add support for Paraflasher to flashrom. >> >> This depends on the external flasher support patch I sent a few minutes ago. >> > > Please feel free to copy the read_memmapped() from your other patch into > flashrom.c to make this patch build, then it's: > > Acked-by: Uwe Hermann <[email protected]> >
Thanks, committed in r473. > As for the rest of the external flasher infrastructure we might want to > discuss the approach we take a little more (see my other mail). > Indeed. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
