On 07.05.2009 14:18, Carl-Daniel Hailfinger wrote: > On 07.05.2009 13:44, Carl-Daniel Hailfinger wrote: > >> Until the ICH SPI driver can handle preopcodes as standalone opcodes, we >> should handle such special opcode failure gracefully on ICH and >> compatible chipsets. >> >> This fixes chip erase on almost all ICH+VIA SPI masters. >> >> Thanks to Ali Nadalizadeh for helping track down this bug! >> >> > > Improved version, refactored to isolate the impact to a single function. > > As a bonus, all invocations of spi_write_enable() now have error checking. > > Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2...@gmx.net> >
Self-acked and committed in r484. I could not leave a killer bug in flashrom any longer. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot