On Tue, May 12, 2009 at 03:55:27PM +0200, Carl-Daniel Hailfinger wrote: > > We should also rename w49f002u.c in another patch to something more > > generic, that code is in no way specific to the w49f002u. Maybe > > even put the only function in that file (byte-wise JEDEC writes of one > > page/sector) into jedec.c? > > > > Sounds like a good idea. Usually, the only thing that differs between > various LPC/FWH flashes is block locking, the rest is identical. Maybe > add a function pointer to struct flashchip which takes > block_locking(struct flashchip chip, enum (LOCK, UNLOCK, CHECK) action, > int start, int len) > That would allow probably even more refactoring. > > > The write_39sf020() and write_49f002() functions are identical except > > for whitespace differences, so drop one of them. > > > > Signed-off-by: Uwe Hermann <[email protected]> > > > > Acked-by: Carl-Daniel Hailfinger <[email protected]>
Thanks, r497. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
